From: Bernt Hansen <bernt@norang.ca>
To: Carsten Dominik <dominik@science.uva.nl>
Cc: Tim O'Callaghan <tim.ocallaghan@gmail.com>,
org-mode <emacs-orgmode@gnu.org>
Subject: Re: Org Remember hooks?
Date: Wed, 19 Nov 2008 08:19:18 -0500 [thread overview]
Message-ID: <8763mjrgyx.fsf@gollum.intra.norang.ca> (raw)
In-Reply-To: 857E0F97-90FB-42EC-A996-E98065B4D25B@uva.nl
Hi Carsten,
Remember mode seems to be broken this morning.
After entering my remember note C-c C-c gives the following error
Debugger entered--Lisp error: (wrong-type-argument commandp org-remember-finalize)
call-interactively(org-remember-finalize)
According to git bisect the following commit breaks it
------------------------------------------------------------------------
fb22510c1c66af3fdfea1b63d09f358e9914a3d3 is first bad commit
commit fb22510c1c66af3fdfea1b63d09f358e9914a3d3
Author: Carsten Dominik <carsten.dominik@gmail.com>
Date: Wed Nov 19 11:49:17 2008 +0100
Use the new minor mode to exit remember buffers.
Since we have now a minor mode in remember buffers, we use its
keymap also to exit and to abort the remember process.
:040000 040000 657feade3fc36b41315bc7db7b850b1319f74e51 37a5014d08cfb38839dfa1c9778ad67f599f4c34 M lisp
------------------------------------------------------------------------
-Bernt
Carsten Dominik <dominik@science.uva.nl> writes:
> Hi Tim,
>
> On Nov 18, 2008, at 6:18 PM, Tim O'Callaghan wrote:
>
>> Hi,
>>
>> I want to change/add to the remember mode key-map but i'm having some
>> problems reverting them.
>> That's because the remember buffer is actually org-mode in disguise,
>> the keys stay mapped after the remember mode buffer is closed.
>>
>> Is it possible to localise the org-remember mappings, or supply a post
>> org-remember hook?
>
> These are both good ideas. You are right that it is bad that it is so
> difficult to change key bindings in Org's version of remember-mode.
> But I think it makes a lot of sense to have the remember buffer
> in Org-mode with all its power.
>
> Here is what I have done now:
>
> 1. Finishing a remember process runs `org-remember-before-finalize-
> hook'.
> You could use this to revert your bindings, but the following
> second option is better:
>
> 2. I have defined a *minor* mode, org-remember-mode with lighter "Rem"
> that is activated when Org-mode is active in a remember buffer.
> You can use its hook `org-remember-mode-hook' or also
> `remember-mode-hook' to install your keys into `org-remember-mode-
> map'.
> It will *not* be necessary to turn off these keys, so for this
> purpose
> you will actually not need `org-remember-before-finalize-hook',
> which may
> find other uses.
>
> This should work (untested):
>
> (defun toc:remap-remember-keys ()
> (define-key org-remember-mode-map [(control x) (control s)]
> remember-finalize)
> (define-key org-remember-mode-map [(meta k)]
> remember-destroy))
> (add-hook 'org-remember-mode-hook 'toc:remap-remember-keys 'append)
>
>
> HTH
>
> - Carsten
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
prev parent reply other threads:[~2008-11-19 13:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 17:18 Org Remember hooks? Tim O'Callaghan
2008-11-18 19:43 ` Carsten Dominik
2008-11-19 13:19 ` Bernt Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763mjrgyx.fsf@gollum.intra.norang.ca \
--to=bernt@norang.ca \
--cc=dominik@science.uva.nl \
--cc=emacs-orgmode@gnu.org \
--cc=tim.ocallaghan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).