From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Bug: inline images for filenames with spaces Date: Thu, 30 Jun 2011 17:41:55 +0200 Message-ID: <8762nn1g3g.fsf@gnu.org> References: <20110629093107.BC5E7C7C0C@fish.malachiarts.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([140.186.70.92]:49192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcJMx-0004nr-M7 for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 11:41:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QcJMs-0005mj-KY for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 11:41:31 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:51663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcJMs-0005lf-6Z for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 11:41:26 -0400 Received: by wwf22 with SMTP id 22so1917510wwf.30 for ; Thu, 30 Jun 2011 08:41:25 -0700 (PDT) In-Reply-To: <20110629093107.BC5E7C7C0C@fish.malachiarts.com> (Huy's message of "Wed, 29 Jun 2011 02:31:07 -0700") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Huy Cc: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Hi Huy, Huy writes: > inline image display doesn't seem to work for image links with spaces in > them. That's because those images will be inserted as [[file:image%20with%20space.png][file:image with space.png]] and such a string is not recognized by the inline displayer. The attached patch fixes this. Please confirm and also take the time to check that there is no side-effects -- especially wrt the exporter. E.g. this LaTeX command: \includegraphics[width=10em]{image with space.png} will result in a problem, with the string "with space.png" just next to the picture. In any case, it's better to avoid spaces in file names. Thanks for reporting this, --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-org.el-don-t-escape-image-links-with-no-description.patch >From 84e18e5fb8dbaee425caffb90bdab9f67dc268de Mon Sep 17 00:00:00 2001 From: Bastien Guerry Date: Thu, 30 Jun 2011 17:35:23 +0200 Subject: [PATCH] org.el: don't escape image links with no description. (org-make-link-string): Don't escape image links when no description is provided by the user. Otherwise those images won't be recognized as images when trying to display inline pictures. --- lisp/org.el | 13 ++++++++----- 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 574ac37..8d71117 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -8686,16 +8686,19 @@ according to FMT (default from `org-email-link-description-format')." (setq description (replace-match "{" t t description))) (while (string-match "\\]" description) (setq description (replace-match "}" t t description)))) - (when (equal (org-link-escape link) description) + (when (equal link description) ;; No description needed, it is identical (setq description nil)) (when (and (not description) + (not (string-match (org-image-file-name-regexp) link)) (not (equal link (org-link-escape link)))) (setq description (org-extract-attributes link))) - (setq link (if (string-match org-link-types-re link) - (concat (match-string 1 link) - (org-link-escape (substring link (match-end 1)))) - (org-link-escape link))) + (setq link + (cond ((string-match (org-image-file-name-regexp) link) link) + ((string-match org-link-types-re link) + (concat (match-string 1 link) + (org-link-escape (substring link (match-end 1))))) + (t (org-link-escape link)))) (concat "[[" link "]" (if description (concat "[" description "]") "") "]")) -- 1.7.5.2 --=-=-= Content-Type: text/plain -- Bastien --=-=-=--