From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Problems with (defvar foo) and Emacs 23 Date: Tue, 03 Apr 2012 07:49:20 +0200 Message-ID: <8762dhs6u7.fsf@gnu.org> References: <87sjgngtzk.fsf@norang.ca> <87aa2vp5ri.fsf@Rainer.invalid> <87aa2vw5mq.fsf@gnu.org> <87y5qfp2wd.fsf@Rainer.invalid> <87398m642v.fsf@gnu.org> <87bonaats8.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:60365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEwbB-0007ZI-03 for emacs-orgmode@gnu.org; Tue, 03 Apr 2012 01:48:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEwb8-0002aY-Ud for emacs-orgmode@gnu.org; Tue, 03 Apr 2012 01:48:08 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:41749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEwb8-0002aM-Kw for emacs-orgmode@gnu.org; Tue, 03 Apr 2012 01:48:06 -0400 Received: by werj55 with SMTP id j55so2788860wer.0 for ; Mon, 02 Apr 2012 22:48:04 -0700 (PDT) In-Reply-To: <87bonaats8.fsf@Rainer.invalid> (Achim Gratz's message of "Mon, 02 Apr 2012 20:11:03 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Hi Achim, Achim Gratz writes: > Bastien writes: >> Let's do some heavy testing against current HEAD and let's carefully >> review code. But let's not panic -- Emacs is still in pretest, that's >> the whole purpose of a pretest. > > It looks like you've already took care of the fixes. Anything that you > specifically want to review? The TODO stuff would not escape Bernt's > scrutiny, I suspect... There are these warnings left while compiling Org in Emacs 24: 1. one about `buffer-substring-filters' 2. one about `entry' not having a prefix 3. one about `date', `annotation', 'initial' not having a prefix We should write a compatibility function to get rid of the first warning. Prefixing `entry' is not straightforward but should be possible. As for the last warnings, I think we'll have to live with it, but chasing down places where *some* instance can be prefixed (or renamed with a more explicit name) could be good. Not a high priority though. Nothing here is critical right now -- thanks for your help! -- Bastien