From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: [PATCH] - Fix org-fast-tag-selection
Date: Tue, 03 Apr 2012 16:29:11 +0200
Message-ID: <8762dgkhxk.fsf@gnu.org>
References: <87fwclayfa.fsf@noman.maa.corp.collab.net>
	<87fwclm2wr.fsf@altern.org>
	<CA+H4GH8_nkYySV2_aEiJrJxNLS0jna4BmL4MVsO7VoyFcsMA=g@mail.gmail.com>
	<87fwckkjds.fsf@altern.org>
	<CA+H4GH_Hfc=w8qOEsethU7WG-EAZ2gJR1da_SgburJzYZq3TPg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:42296)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <bzg@gnu.org>)
	id 1SF4iK-0007bJ-0v
	for emacs-orgmode@gnu.org; Tue, 03 Apr 2012 10:28:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bzg@gnu.org>) id 1SF4iC-0000hX-Cf
	for emacs-orgmode@gnu.org; Tue, 03 Apr 2012 10:28:03 -0400
Received: from incoming2.cnam.fr ([163.173.128.34]:54904)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <bzg@gnu.org>)
	id 1SF4iC-0000h1-76
	for emacs-orgmode@gnu.org; Tue, 03 Apr 2012 10:27:56 -0400
In-Reply-To: <CA+H4GH_Hfc=w8qOEsethU7WG-EAZ2gJR1da_SgburJzYZq3TPg@mail.gmail.com>
	(Noorul Islam Kamal Malmiyoda's message of "Tue, 3 Apr 2012 19:32:21
	+0530")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Noorul Islam Kamal Malmiyoda <noorul@noorul.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>

Noorul Islam Kamal Malmiyoda <noorul@noorul.com> writes:

> Not necessary this time.

Okay, thanks.

I amended http://orgmode.org/worg/org-contribute.html to explain why
patches made with `git format-patch' are always preferred, even small
patches.

I'm less and less using Patchwork as a way to apply patches, because I
find commit messages to be sometimes messy that way.

Instead, I have local folders with patches I want to apply/review/etc.
I patch Org using `git apply' when I want to test, `git am' when I want
to commit a properly formatted patch.

It means that for each patch that doesn't have a ChangeLog, I have to 
(1) add it myself and (2) manually use git commit --author="<author>"
to have the correct author displayed.

To summarize, whether the patch is *small or big* is not the right
criterium to decide whether a simple `git diff' is acceptable -- it's
more about whether the patch is sent for testing purpose first, or
whether it is considered applicable as such.

Thanks!

-- 
 Bastien