From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Peter_M=C3=BCnster?= <pmlists@free.fr>
Subject: Re: [PATCH 2/2] org-notify: Fix compatibility with latest
 org-element (uppercase properties)
Date: Thu, 27 Jun 2013 18:41:59 +0200
Message-ID: <8761wzbj54.fsf@micropit.couberia.selfip.net>
References: <1371586950-20217-1-git-send-email-pmlists@free.fr>
	<1371586950-20217-2-git-send-email-pmlists@free.fr>
	<87li5voarm.fsf@bzg.ath.cx>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60336)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1UsFIr-0000WK-8w
	for emacs-orgmode@gnu.org; Thu, 27 Jun 2013 12:44:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1UsFIp-00040X-Ig
	for emacs-orgmode@gnu.org; Thu, 27 Jun 2013 12:44:13 -0400
Received: from plane.gmane.org ([80.91.229.3]:35519)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1UsFIp-00040S-CJ
	for emacs-orgmode@gnu.org; Thu, 27 Jun 2013 12:44:11 -0400
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1UsFIm-0004rQ-Ni
	for emacs-orgmode@gnu.org; Thu, 27 Jun 2013 18:44:08 +0200
Received: from arennes-651-1-215-231.w90-32.abo.wanadoo.fr ([90.32.142.231])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Thu, 27 Jun 2013 18:44:08 +0200
Received: from pmlists by arennes-651-1-215-231.w90-32.abo.wanadoo.fr with
	local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Thu, 27 Jun 2013 18:44:08 +0200
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

On Thu, Jun 27 2013, Bastien wrote:

>> * contrib/lisp/org-notify.el (org-notify-make-todo): Properties from
>> org-element are all uppercase now.
>
> Mhh... not sure what it means -- do you have a pointer?

Yes, here: http://article.gmane.org/gmane.emacs.orgmode/73628

Citation:

  | (defun org-element-headline-parser (limit &optional raw-secondary-p)
  |   "Parse a headline.
  |
  | Return a list whose CAR is `headline' and CDR is a plist
  | containing `:raw-value', `:title', `:alt-title', `:begin',
  | `:end', `:pre-blank', `:hiddenp', `:contents-begin' and
  | `:contents-end', `:level', `:priority', `:tags',
  | `:todo-keyword',`:todo-type', `:scheduled', `:deadline',
  | `:closed', `:quotedp', `:archivedp', `:commentedp' and
  | `:footnote-section-p' keywords.
  |
  | The plist also contains any property set in the property drawer,
  | with its name in upper cases and colons added at the
  | beginning (i.e. `:CUSTOM_ID').
  |
        [...]


>> -    (let* ((list (nth 1 heading))      (notify (or (get :notify) "default"))
>> +    (let* ((list (nth 1 heading))      (notify (or (get :NOTIFY) "default"))
>
> I feel dull: please let me know why this is needed.

No problem. Here another pointer:
http://article.gmane.org/gmane.emacs.orgmode/73637

-- 
           Peter