emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Rasmus <rasmus@gmx.us>
Cc: alan.schmitt@polytechnique.org, emacs-orgmode@gnu.org
Subject: Re: [patch][ox-koma-letter] set opening via headline
Date: Sat, 17 Aug 2013 21:42:26 +0200	[thread overview]
Message-ID: <8761v4umsd.fsf@gmail.com> (raw)
In-Reply-To: <877gfk6s5f.fsf@gmx.us> (rasmus@gmx.us's message of "Sat, 17 Aug 2013 21:20:28 +0200")

Hello,

Rasmus <rasmus@gmx.us> writes:

> With the following patch one can set the opening via a headline.
> Currently, it's pretty conservative and will only set opening if it
> isn't set already.  I'm open to discussion on that point.

Here are some comments about its internals.

>  (defcustom org-koma-letter-opening nil
> -  "Letter's opening, as a string."
> +  "Letter's opening, as a string.  If (1) this value is nil; (2)

Please start a new line after the first sentence.

> +(defcustom org-koma-letter-headline-is-opening-maybe t
> +  "Whether a headline may be used as an opening.  A headline is

Ditto.

> +      (unless (or (plist-get info :opening)
> +		  (not org-koma-letter-headline-is-opening-maybe))
> +	(plist-put info :opening (org-element-property :raw-value headline)))

I suggest to use

  (org-export-data (org-element-property :title headline) info)

instead, so you can correctly export Org syntax included in the
headline, if any.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2013-08-17 19:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-17 19:20 [patch][ox-koma-letter] set opening via headline Rasmus
2013-08-17 19:42 ` Nicolas Goaziou [this message]
2013-08-17 20:07   ` Rasmus
2013-08-17 20:55     ` [patch][ox-koma-letter] checkdoc compatible (was: [patch][ox-koma-letter] set opening via headline) Rasmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761v4umsd.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=alan.schmitt@polytechnique.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=rasmus@gmx.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).