[bug] aorg-agenda effort filter

[bug] aorg-agenda effort filter

[Achim Gratz]

The recent commit aa86e4bc9f extends a pre-existing setq via the
following diff:

--8<---------------cut here---------------start------------->8---
@@ -7615,11 +7656,12 @@ (defun org-agenda-filter-apply (filter type)
 		    (apply 'append
 			   (mapcar (lambda (f)
 				     (org-agenda-filter-expand-tags (list f) t))
 				   (org-get-at-bol 'tags)))
 		    cat (org-get-at-eol 'org-category 1)
-		    txt (get-text-property (point) 'txt))
+		    txt (org-get-at-eol 'txt 1)
+		    effort-minutes (org-get-at-eol 'effort-minutes 1))
 	      (if (not (eval org-agenda-filter-form))
 		  (org-agenda-filter-hide-line type))
 	      (beginning-of-line 2))
 	  (beginning-of-line 2))))
     (if (get-char-property (point) 'invisible)
--8<---------------cut here---------------end--------------->8---

Setting effort-minutes here is a bug since it is a property and not a
variable.  Adding it to the let clause this statement is in would
suppress the corresponding warning, but I don't see where such a
let-bound variable would be used.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

Re: [bug] aorg-agenda effort filter

[Bastien]

Hi Achim,

Achim Gratz <Stromeko@nexgo.de> writes:

> Setting effort-minutes here is a bug since it is a property and not a
> variable.  Adding it to the let clause this statement is in would
> suppress the corresponding warning, but I don't see where such a
> let-bound variable would be used.

This is a left-overt from test code, this is now fixed, thanks.

PS: You committed stuff in maint that belong to master at this stage.
Also, the commit messages contain references like 'variable' instead
of `variable'.  A tiny difference, sure, but one that I will have to
fix manually when merging the Changelogs into Emacs.

-- 
 Bastien

Re: [bug] aorg-agenda effort filter

[Achim Gratz]

Bastien writes:
> Also, the commit messages contain references like 'variable' instead
> of `variable'.  A tiny difference, sure, but one that I will have to
> fix manually when merging the Changelogs into Emacs.

The corresponding GNU coding standard has been changed about a year ago
and EMACS is slowly following suit.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

Re: [bug] aorg-agenda effort filter

[Bastien]

Achim Gratz <Stromeko@nexgo.de> writes:

> Bastien writes:
>> Also, the commit messages contain references like 'variable' instead
>> of `variable'.  A tiny difference, sure, but one that I will have to
>> fix manually when merging the Changelogs into Emacs.
>
> The corresponding GNU coding standard has been changed about a year
> ago

Do you have a pointer?

> and EMACS is slowly following suit.

Where do you see that Emacs is slowly following suit?

I don't see any occurrence of 'variable' in any Changelog.

-- 
 Bastien

Re: [bug] aorg-agenda effort filter

[Achim Gratz]

Bastien writes:
> Achim Gratz <Stromeko@nexgo.de> writes:
>
>> Bastien writes:
>>> Also, the commit messages contain references like 'variable' instead
>>> of `variable'.  A tiny difference, sure, but one that I will have to
>>> fix manually when merging the Changelogs into Emacs.
>>
>> The corresponding GNU coding standard has been changed about a year
>> ago
>
> Do you have a pointer?

http://www.gnu.org/prep/standards/standards.html#index-left-quote

The actual change to the document was made even earlier than I
remembered:

--8<---------------cut here---------------start------------->8---
2011-12-31  Paul Eggert  <eggert@cs.ucla.edu>

	* standards.texi (Quote Characters): change to recommending
	undirected quotes, '...' or "...".
--8<---------------cut here---------------end--------------->8---


>> and EMACS is slowly following suit.
>
> Where do you see that Emacs is slowly following suit?

There was a lengthy discussion around the latest version of makeinfo
producing the new quoting style by default just recently and it has
flared up before.  My takeaway from that was that EMACS would go with
that change in coding style over time.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

Re: [bug] aorg-agenda effort filter

[Bastien]

Achim Gratz <Stromeko@nexgo.de> writes:

> http://www.gnu.org/prep/standards/standards.html#index-left-quote
>
> The actual change to the document was made even earlier than I
> remembered:
>
> 2011-12-31  Paul Eggert  <eggert@cs.ucla.edu>
>
> 	* standards.texi (Quote Characters): change to recommending
> 	undirected quotes, '...' or "...".

This is about the quote character as an output, not as used in Emacs
change logs. 

>>> and EMACS is slowly following suit.
>>
>> Where do you see that Emacs is slowly following suit?
>
> There was a lengthy discussion around the latest version of makeinfo
> producing the new quoting style by default just recently and it has
> flared up before.  My takeaway from that was that EMACS would go with
> that change in coding style over time.

No, the convention is still to use ` for variables in change logs.
This is the same as using `variable' in Emacs lisp buffers (see line
343 of current trunk in lisp-mode.el, where `font-lock-constant-face'
is used for highlighting variables.)

-- 
 Bastien

Re: [bug] aorg-agenda effort filter

[Achim Gratz]

Bastien writes:
> This is about the quote character as an output, not as used in Emacs
> change logs. 

I can't find this stipulation anywhere in the official docs.

https://www.gnu.org/software/emacs/manual/html_node/emacs/Format-of-ChangeLog.html
https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html

Clearly the quoting style used in the changelog entries follows the GNU
coding style, which has now changed from the former preference of using
backticks as the left quote character to single quotes (the second
document already uses the new style in the example).  In fact it isn't
even talking about needing to always use quotes (it is more consistent
to always use them, but at least for prefixed names there is no
ambiguity of what was meant to begin with).

> No, the convention is still to use ` for variables in change logs.

You might ask Stefan for a policy decision, although I can't see why the
Emacs project would deviate from the GNU coding standard in this regard.

> This is the same as using `variable' in Emacs lisp buffers (see line
> 343 of current trunk in lisp-mode.el, where `font-lock-constant-face'
> is used for highlighting variables.)

Now you're talking about docstrings and I'll expect that this will also
change, albeit much more slowly.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Samples for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldSamplesExtra

Re: [bug] aorg-agenda effort filter

[Bastien]

I don't think the pointers are relevant to whether Emacs should use
`symbol' or 'symbol' in change logs and docstrings.  I asked for a
confirmation on the emacs-devel list, let's see.

Thanks,

-- 
 Bastien