From: Thorsten Jolitz <tjolitz@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [FeatReq] New option for `org-entry-properties' WHICH argument?
Date: Mon, 28 Jul 2014 23:11:36 +0200 [thread overview]
Message-ID: <8761ihw5mf.fsf@gmail.com> (raw)
In-Reply-To: 87wqaxz98v.fsf@bzg.ath.cx
Bastien <bzg@gnu.org> writes:
Hi Bastien,
> Thorsten Jolitz <tjolitz@gmail.com> writes:
>
>> what about adding one more option for WHICH
>>
>> ,----[ C-h f org-entry-properties RET ]
>> | org-entry-properties is a compiled Lisp function in `org.el'.
>> |
>> | (org-entry-properties &optional POM WHICH SPECIFIC)
>> | [...]
>> | If WHICH is nil or `all', get all properties. If WHICH is
>> | `special' or `standard', only get that subclass. If WHICH
>> | is a string only get exactly this property. SPECIFIC can be a
>> | string, the
>> | specific property we are interested in. Specifying it can speed
>> | things up because then unnecessary parsing is avoided.
>> `----
>>
>> that would filter out all Org related properties, i.e. the properties
>> the system itself uses, and thus return only the application related
>> properties?
>>
>> E.g. option 'non-org'
>
> You mean `non-special' or `non-standard'? I.e. all properties that
> are not listed as special properties?
yes, I mean filtering out as many special, standard or otherwise
'wellknown' system-properties and return just the remaining
application/user-defined properties.
> Yes, I see how it would be useful.
>
> Can you provide a patch for this?
I had a look, and its not as trivial as I thought. This function clearly
predates the new parser, it does not make use of variables like
,----
| org-custom-properties
| org-default-properties
| org-global-properties
| org-global-properties-fixed
| org-special-properties
| org-element-document-properties
| org-taskjuggler-default-global-properties
`----
and the way it is written I cannot simply add another 'case' or 'cond'
statement to get all properties that are not special or standard.
So what would be the strategy here?
- complete rewrite based on the new parser (and making use of the above
mentioned variables)?
- some heavy refactoring, on the line of adding let-bindings for the
special and standard properties and introducing a '(case which ()...)
expression with fallback to 'all?
- ask the maintainer for a hint towards a smarter less intrusive
solution?
--
cheers,
Thorsten
next prev parent reply other threads:[~2014-07-28 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 21:21 [FeatReq] New option for `org-entry-properties' WHICH argument? Thorsten Jolitz
2014-06-27 2:52 ` Matt Lundin
2014-07-28 13:23 ` Bastien
2014-07-28 21:11 ` Thorsten Jolitz [this message]
2014-07-29 14:58 ` Bastien
2014-07-29 15:43 ` Thorsten Jolitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761ihw5mf.fsf@gmail.com \
--to=tjolitz@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).