From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes
Date: Thu, 07 May 2015 22:09:06 +0200
Message-ID: <876184i1zx.fsf@nicolasgoaziou.fr>
References: <CAL5NfX3Mqp3Q4Ngs8obhVPzn9si6p=07ZuawAh_LKNhoN=6H=g@mail.gmail.com>
	<874mo58oa5.fsf@kmlap.domain.org>
	<CAL5NfX2YMpwX6pSK_taJQbWKLq9bZfYUjHTqC-=RobSd2mrvzA@mail.gmail.com>
	<87pp6kk7lg.fsf@nicolasgoaziou.fr>
	<CAL5NfX3+OKgxb+2pbMeAF-j8E24LE33rZ9JVjwxbbA9=a_t=ww@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38092)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YqS59-000630-Mo
	for emacs-orgmode@gnu.org; Thu, 07 May 2015 16:07:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YqS58-0000Tr-SE
	for emacs-orgmode@gnu.org; Thu, 07 May 2015 16:07:43 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:38411)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YqS58-0000T9-Ln
	for emacs-orgmode@gnu.org; Thu, 07 May 2015 16:07:42 -0400
In-Reply-To: <CAL5NfX3+OKgxb+2pbMeAF-j8E24LE33rZ9JVjwxbbA9=a_t=ww@mail.gmail.com>
	(Brice Waegenire's message of "Tue, 5 May 2015 16:34:29 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Brice Waegenire <brice.wge@gmail.com>
Cc: emacs-orgmode@gnu.org

Brice Waegenire <brice.wge@gmail.com> writes:

> Thanks for help on this!
> Here is the last version of the patch taking into account all of your
> comments.

Thank you.

>  		     (read-from-minibuffer
> -		      "How many minutes left? "
> -		      (if (not (eq org-timer-default-timer 0))
> -			  (number-to-string org-timer-default-timer))))))
> +		      "How much time left? (minutes or h:mm:ss) "
> +		      (when (not (string-equal org-timer-default-timer "0"))

Nitpick: `unless'

> +			  (eval org-timer-default-timer))))))

Since `org-timer-default-timer' is a string, there's no need to eval it.

BTW, did you sign FSF papers already? If not, you need to add TINYCHANGE
to the end of the commit message.


Regards,