From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [rfc] org-dired Date: Wed, 15 Nov 2017 12:38:37 +0100 Message-ID: <8760abzs8y.fsf@nicolasgoaziou.fr> References: <84bmk7ttkh.fsf@gmail.com> <87mv3r1mgh.fsf@nicolasgoaziou.fr> <84inebztpf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEw1o-0001mu-9o for emacs-orgmode@gnu.org; Wed, 15 Nov 2017 06:38:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEw1k-0008Ak-5o for emacs-orgmode@gnu.org; Wed, 15 Nov 2017 06:38:48 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:46696) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eEw1k-00089b-08 for emacs-orgmode@gnu.org; Wed, 15 Nov 2017 06:38:44 -0500 In-Reply-To: <84inebztpf.fsf@gmail.com> (Marco Wahl's message of "Wed, 15 Nov 2017 12:07:08 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Marco Wahl Cc: emacs-orgmode@gnu.org Hello, Marco Wahl writes: > I just pushed the functionality to master. Thank you.=20 However, I didn't have time to comment the code. There are a few stylistic issues: `mapc' + `lambda' -> `dolist' in `org-attach-attach-files'.=20=20 However, I think `org-attach-attach-files' can be removed, since it is called only once and is really two lines long. IOW, please include it in `org-attach-dired-attach-to-next-best-subtree'. "no window in Org-mode" -> "No window displaying an Org buffer" I don't think it is useful to implement `org-attach-dired-attach-to-next-best-subtree-mv'. I assume that once `org-attach-method' is set, a user is unlikely to change it for a single command. IOW, let's just implement `org-attach-dired-attach-to-next-best-subtree'. Nitpick: an inline comment uses a single semicolon. It would also be better to shorten function names, e.g. org-attach-dired-attach-to-next-best-subtree -> org-attach-dired-to-sub= tree There are also a few issues in "test-org-attach.el". For example `touch' uses the wrong name-space. Besides, it is not useful. We usually do (org-test-with-temp-text-in-file=20 "... Org bufer..." (let ((filename (buffer-file-name))) ...)) It would be best to refactor `test-org-attach/dired-attach-to-next-best-subtree/1' so that `should' is the outer sexp. The cleanup part should probably be in an `unwind-protect'. Not that it is not useful if =C2=B0org-test-with-temp-text-in-file'. Regards, --=20 Nicolas Goaziou