From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: John Lee <jjl@pobox.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-habit: allow overriding org-scheduled-past-days and always including time of day
Date: Sat, 02 Feb 2019 22:45:24 +0100 [thread overview]
Message-ID: <875zu1dfuz.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <1549133427.1633527.1649374424.31A6A12F@webmail.messagingengine.com> (John Lee's message of "Sat, 02 Feb 2019 18:50:27 +0000")
Hello,
John Lee <jjl@pobox.com> writes:
> Hi, sorry Nicolas I totally missed your review comments!
No problem.
> Trying hard to make up a reason for utility of the current behaviour:
> let's say your habits tend to be weekly and have an optimum time and
> weekday, but if you miss them it's just "as soon as possible". But if
> anybody actually does see their habits that way, that would seem
> likely to vary by habit. So I'd be surprised if the current behaviour
> was very useful.
>
> Shall I make it the default, then?
I think so.
> Thank you. Right now I have one other change I'd like to submit which
> is also tiny, do I need to start the assignment process?
If both changes do not add up to around 15 non-trivial locs, that's
fine.
>> > +(defcustom org-habit-scheduled-past-days nil
>> > + "Non-nil means the value of this variable will be used instead
>> > +of org-scheduled-past-days, for habits only.
>>
>> First line needs to be a full sentence. Also,
>
> To me it looks like a full sentence?
What I meant is the first line should contain only full sentences. Yours
spans over two lines.
> Should it be something like this below (based on looking at other docstrings)?
>
> "Value to use instead of `org-scheduled-past-days', for habits only.
>
> If nil, `org-scheduled-past-days' is used."
That's better, indeed.
> I think "as a mean of" is not correct English (I'm a native speaker in
> the UK).
Of course, you're right. Sorry for the noise.
> Presumably I should use the version from the highest current git tag "plus one", i.e. 9.3?
>
> :package-version '(Org . "9.3")
That's correct.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2019-02-02 21:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 0:31 org-habit: allow overriding org-scheduled-past-days and always including time of day John Lee
2018-11-05 13:01 ` [PATCH] " John Lee
2018-11-18 23:40 ` Nicolas Goaziou
2019-02-02 18:50 ` John Lee
2019-02-02 21:45 ` Nicolas Goaziou [this message]
2019-02-03 15:53 ` John Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zu1dfuz.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=jjl@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).