emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* org-scheduled-time-hour-regexp doesn't capture split repeats used by habit
@ 2019-06-27  4:11 Damian
  2020-02-04  7:59 ` Bastien
  0 siblings, 1 reply; 2+ messages in thread
From: Damian @ 2019-06-27  4:11 UTC (permalink / raw)
  To: emacs-orgmode

The ':scheduled*' value for org-agenda-entry-types uses 
org-scheduled-time-hour-regexp to match related entries. The current 
regexp doesn't match entries with split repeats like those used by 
habits- for example:       'SCHEDULED: <2019-06-25 Tue 20:30 .+1d/2d>'. 
Because those entries show up in the agenda with a timestamp I believe 
they should be caught by the regexp.

org.el:
      (defconst org-scheduled-time-hour-regexp
           (concat "\\<" org-scheduled-string
                   " *<\\([^>]+[0-9]\\{1,2\\}:[0-9]\\{2\\}[0-9+:hdwmy 
\t.-]*\\)>")
           "Matches the SCHEDULED keyword together with a time-and-hour 
stamp.")

Fix?
    (defconst org-scheduled-time-hour-regexp
           (concat "\\<" org-scheduled-string
                   " *<\\([^>]+[0-9]\\{1,2\\}:[0-9]\\{2\\}[0-9+:hdwmy 
\t./-]*\\)>")
           "Matches the SCHEDULED keyword together with a time-and-hour 
stamp.")

Thanks,
-Damian

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: org-scheduled-time-hour-regexp doesn't capture split repeats used by habit
  2019-06-27  4:11 org-scheduled-time-hour-regexp doesn't capture split repeats used by habit Damian
@ 2020-02-04  7:59 ` Bastien
  0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2020-02-04  7:59 UTC (permalink / raw)
  To: Damian; +Cc: emacs-orgmode

Hi Damian,

> The ':scheduled*' value for org-agenda-entry-types uses
> org-scheduled-time-hour-regexp to match related entries. The current 
> regexp doesn't match entries with split repeats like those used by
> habits- for example:       'SCHEDULED: <2019-06-25 Tue 20:30
> .+1d/2d>'. Because those entries show up in the agenda with a
> timestamp I believe they should be caught by the regexp.

thanks for reporting this, this is now fixed in the maint branch.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-04  7:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-27  4:11 org-scheduled-time-hour-regexp doesn't capture split repeats used by habit Damian
2020-02-04  7:59 ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).