emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug#42184: org-fontify-whole-*-line in emacs 27
Date: Sun, 09 Aug 2020 15:27:39 -0400	[thread overview]
Message-ID: <875z9rtyac.fsf@kyleam.com> (raw)
In-Reply-To: <87eeofaowv.fsf@gmail.com>

Kévin Le Gouguec writes:

> Huh.  Based on the discussion for bug#37774[1][2][3][4], I had assumed
> this kind of kludge would be necessary, but both Emacs 25.3 and 26.3
> seem to evaluate and byte-compile the following snippet with no errors:
>
> #+begin_src elisp
> (defface foobar '((t (:extend t)))
>   "Test extend in 26.3"
>   :group 'org-faces)
>
> (custom-set-faces
>  '(foobar ((t (:extend nil))) t))
> #+end_src
>
> Obviously I'm all for removing this shim if it's not needed.  From some
> light testing it looks like removing it breaks the customization widget,
> though?

Ah, good point.  I didn't think to check that in my testing, and indeed
it looks broken.  Okay, let's go with

  `((t :inherit shadow ,@(and (>= emacs-major-version 27) '(:extend t))))

as the org-block spec then.

Thanks.


  reply	other threads:[~2020-08-09 19:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-10  9:23 Couple of issues with org block meta lines faces Sébastien Miquel
2020-07-10 11:46 ` Kévin Le Gouguec
2020-07-14 10:19   ` Bug#42184: org-fontify-whole-*-line in emacs 27 (was: Couple of issues with org block meta lines faces) Kévin Le Gouguec
2020-08-02 21:23     ` Bug#42184: org-fontify-whole-*-line in emacs 27 Kévin Le Gouguec
2020-08-07  0:44       ` Kyle Meyer
2020-08-07  9:26         ` Kévin Le Gouguec
2020-08-09  4:43           ` Kyle Meyer
2020-08-09 14:12             ` Kévin Le Gouguec
2020-08-09 19:27               ` Kyle Meyer [this message]
2020-08-10 13:27                 ` Kévin Le Gouguec
2020-08-11  0:43                   ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z9rtyac.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=kevin.legouguec@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).