emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Dr. Arne Babenhauserheide" <arne_bab@web.de>
To: emacs-orgmode@gnu.org
Subject: Bug: [patch] fix: ox-rss died when an entry had an empty date [ ( @ /home/arne/.guix-profile/share/emacs/site-lisp/)]
Date: Thu, 07 Jan 2021 02:56:25 +0100	[thread overview]
Message-ID: <875z49echi.fsf@web.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 2307 bytes --]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See


Your bug report will be posted to the Org mailing list.

When creating an RSS feed, org-publish broke for me with

  signal(error ("Not an Org time string: "))
  error("Not an Org time string: %s" "")
  (format-time-string "%a, %d %b %Y %H:%M:%S %z" (org-time-string-to-time pubdate0))
  (if pubdate0 (format-time-string "%a, %d %b %Y %H:%M:%S %z" (org-time-string-to-time pubdate0)))
  ;; …
  org-rss-headline((headline ... ...) #("<p>\nIch bin ei..." 4 395 ... 407 410 ... 492 530 ... 534 535 ... ...) (:export-options nil :back-end ... :translate-alist ... :exported-data #<hash-table eq 836/4001 0x20766a9> :input-buffer "rss-feed.org" :input-file "/home/arne/Sch..." :description "" ...))

Maybe relevant: I have date enabled in options.
#+OPTIONS: date:t

Best wishes,

From 17b6ba6f9adcd42e03ae2b606043719b2926641a Mon Sep 17 00:00:00 2001
From: Arne Babenhauserheide <arne_bab@web.de>
Subject: [PATCH] ox-rss: do not die on empty date

* contrib/lisp/ox-rss.el (org-rss-headline): check for empty string
 contrib/lisp/ox-rss.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/lisp/ox-rss.el b/contrib/lisp/ox-rss.el
index 299d22086..97a4bfc8f 100644
--- a/contrib/lisp/ox-rss.el
+++ b/contrib/lisp/ox-rss.el
@@ -245,7 +245,7 @@ communication channel."
 			(or (org-element-property :CATEGORY headline) "") info))
 	     (pubdate0 (org-element-property :PUBDATE headline))
 	     (pubdate (let ((system-time-locale "C"))
-			(if pubdate0
+			(if (and pubdate0 (not (string-empty-p pubdate0))
 			     "%a, %d %b %Y %H:%M:%S %z"
 			     (org-time-string-to-time pubdate0)))))

Emacs  : GNU Emacs 27.1 (build 1, x86_64-unknown-linux-gnu, GTK+ Version 3.24.23, cairo version 1.16.0)
Package: Org mode version  ( @ /home/arne/.guix-profile/share/emacs/site-lisp/)
Unpolitisch sein
heißt politisch sein
ohne es zu merken

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 1125 bytes --]

             reply	other threads:[~2021-01-07  1:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07  1:56 Dr. Arne Babenhauserheide [this message]
2021-01-10 23:08 ` Bug: [patch] fix: ox-rss died when an entry had an empty date [ ( @ /home/arne/.guix-profile/share/emacs/site-lisp/)] Kyle Meyer
2021-04-30  7:04   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z49echi.fsf@web.de \
    --to=arne_bab@web.de \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).