From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4umsHfVQXWDeYQEAgWs5BA (envelope-from ) for ; Fri, 26 Mar 2021 04:11:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eDppFvVQXWABYwAAbx9fmQ (envelope-from ) for ; Fri, 26 Mar 2021 03:11:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2FC562EE7B for ; Fri, 26 Mar 2021 04:11:49 +0100 (CET) Received: from localhost ([::1]:51744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPct1-00076J-5V for larch@yhetil.org; Thu, 25 Mar 2021 23:11:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPcsG-00073B-9x for emacs-orgmode@gnu.org; Thu, 25 Mar 2021 23:11:00 -0400 Received: from mx1.riseup.net ([198.252.153.129]:46300) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPcsD-0008Vk-Ch for emacs-orgmode@gnu.org; Thu, 25 Mar 2021 23:10:59 -0400 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4F66Ry5dqrzDxcl; Thu, 25 Mar 2021 20:10:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1616728254; bh=mI3mGgXo8lYtNQP9JWPRvg5N2m+5Uecad4gnYyAJlD0=; h=References:From:To:Cc:Subject:In-reply-to:Date:From; b=sy19tNMEj6DF7f5hvnygq3DHGdl8L3IP8DdlNj3Yb5CZuVS/7cW703t41ARp5SV+z tU1W1wmXOIaLdH4sNL72pHM6In84KkHAH/i1jBYlv8b1qVpA0nmPmF7OabVZv0zCnQ 39i3u6DWXWJteu3sN6OiV9bCmoi+9CJ5iFAbx/sQ= X-Riseup-User-ID: 85E5D3C3A5F0445CBF3D0A26590BE0650EE01A9DC300187DCA4DF597852C155A Received: from host (unknown [185.220.101.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by fews1.riseup.net (Postfix) with ESMTPSA id 4F66Rw4GGzz5vhN; Thu, 25 Mar 2021 20:10:52 -0700 (PDT) References: <87blbtxnho.fsf@host.localdomain> <87wnu0tffu.fsf@kyleam.com> From: pillule To: Kyle Meyer Subject: Re: [PATCH] org-src.el Do not ask to revert unmodified buffers Message-ID: <875z1eehla.fsf@host.localdomain> In-reply-to: <87wnu0tffu.fsf@kyleam.com> Date: Fri, 26 Mar 2021 03:10:00 +0000 MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=198.252.153.129; envelope-from=pillule@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_BL_SPAMCOP_NET=1.347, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pillule , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 2FC562EE7B X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: j8OjQcFtPD91 You are right I clearly missed org-src-ask-before-returning-to-edit-buffer Don't know how . . . Sorry for the noise. Kyle Meyer writes: > Thanks for the patch. > > pillule writes: > >> Hi, it is asked to the user if we want to revert changes when >> re-entering in a org-source buffer. >> Even if the buffer have no modifications. > > Hmm, that description seems to be focusing on the prompt's > parenthetical > note. When org-src-ask-before-returning-to-edit-buffer is > non-nil and > there's an existing source buffer, the caller is asked whether > to return > to it or regenerate/overwrite it. The message warns that the > second > option (i.e. answering "no, don't return to existing buffer") > will > discard changes. > > It looks like this patch assumes that, when the buffer is > unmodified, > the answer to the above question necessarily becomes "yes, > return to the > existing buffer", but it's not clear to me why that should be. > With an > unmodified buffer, I suppose there's less of a difference > between the > two answers, but at least with the default org-src-window-setup > value, > there's still a user-visible difference in terms of window > organization. --