emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Maxim Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: citations: rx problems with emacs-26.3
Date: Wed, 11 Aug 2021 11:18:32 +0200	[thread overview]
Message-ID: <875ywccpav.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <sernjh$15dk$1@ciao.gmane.io> (Maxim Nikulin's message of "Tue, 10 Aug 2021 00:10:25 +0700")

Hello,

Maxim Nikulin <manikulin@gmail.com> writes:

> On 08/08/2021 03:27, Nicolas Goaziou wrote:
>> Maxim Nikulin writes:
>> 
>>> It seems, rx e.g. in emacs-26.3 does not support all features used in
>>> oc.el and oc-csl.el. Loading an org file using git master, I get
>>> a warning
>>>
>>>> Eager macro-expansion failure: (error "rx form ‘regexp’ requires args satisfying ‘stringp’")
>> Thanks. Could you send the patch again with a proper commit message,
>> using git format-patch?
>
> With the attached patches I do not see warnings any more while org is
> loading. On the other hand I am not an org-cite user,

Applied. Thank you.

> so I am not sure that nothing is broken by these patches.

I'll trust the test suite on this.

Regards,
-- 
Nicolas Goaziou


      reply	other threads:[~2021-08-11  9:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-11 10:36 citations: rx problems with emacs-26.3 Maxim Nikulin
2021-08-07 20:27 ` Nicolas Goaziou
2021-08-08 13:34   ` Maxim Nikulin
2021-08-08 14:14     ` Nicolas Goaziou
2021-08-09 17:18       ` Maxim Nikulin
2021-08-11  5:37         ` Axel Kielhorn
2021-08-11  9:33         ` Nicolas Goaziou
2021-08-11 16:24           ` Maxim Nikulin
2021-08-09 17:10   ` Maxim Nikulin
2021-08-11  9:18     ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875ywccpav.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=manikulin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).