From: Jack Kamm <jackkamm@gmail.com>
To: Jeremie Juste <jeremiejuste@gmail.com>, Org Mode <emacs-orgmode@gnu.org>
Cc: "Berry, Charles" <ccberry@health.ucsd.edu>
Subject: Re: [PATCH] async process in R
Date: Sat, 02 Oct 2021 16:14:50 -0700 [thread overview]
Message-ID: <875yufow7p.fsf@gmail.com> (raw)
In-Reply-To: <87bl47ox5y.fsf@gmail.com>
I just noticed one more thing, regarding ess-eval-visibly etc:
>> + (setq user-inject-src-param ess-inject-source)
>> (setq ess-eval-visibly nil)
>> + (setq ess-inject-source 'function-and-buffer)
>> (ess-eval-buffer nil))
>> - (setq ess-eval-visibly tmp)
>> + (setq ess-eval-visibly tmp)
>> + (setq ess-inject-source user-inject-src-param)
>
> Rather than using setq, it would be better to let bind these like so:
>
> (let ((ess-eval-visibly nil)
> (ess-inject-source 'function-and-buffer))
> ...code in here...
> )
I noticed these variables are only reset to defaults when ":results
output". It may also be necessary to set them as well for the case of
":results value". In my original implementation [1], I set
"ess-eval-visibly" within the wrapping advice function, so it applied to
all cases.
[1] https://github.com/jackkamm/ob-session-async/blob/master/lisp/ob-session-async-R.el
prev parent reply other threads:[~2021-10-02 23:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 17:13 [PATCH] async process in R Jeremie Juste
2021-09-26 18:33 ` Greg Minshall
2021-09-26 19:52 ` Jeremie Juste
2021-09-27 4:04 ` Greg Minshall
2021-09-27 6:48 ` Bastien
2021-09-27 19:21 ` Jeremie Juste
2021-09-28 3:02 ` Jack Kamm
2021-09-27 8:18 ` Bastien
2021-09-27 18:28 ` Berry, Charles via General discussions about Org-mode.
2021-09-27 19:25 ` Jeremie Juste
2021-09-27 20:28 ` Jeremie Juste
2021-09-27 22:56 ` Berry, Charles via General discussions about Org-mode.
2021-09-27 23:40 ` Berry, Charles via General discussions about Org-mode.
2021-09-28 7:34 ` Jeremie Juste
2021-09-28 18:22 ` Berry, Charles via General discussions about Org-mode.
2021-09-28 20:40 ` Jeremie Juste
2021-10-02 22:57 ` Jack Kamm
2021-10-02 22:54 ` Jack Kamm
2021-10-02 23:14 ` Jack Kamm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yufow7p.fsf@gmail.com \
--to=jackkamm@gmail.com \
--cc=ccberry@health.ucsd.edu \
--cc=emacs-orgmode@gnu.org \
--cc=jeremiejuste@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).