From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yhDZKa2NFWNwJgAAbAwnHQ (envelope-from ) for ; Mon, 05 Sep 2022 07:48:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WFq7KK2NFWN5egEA9RJhRA (envelope-from ) for ; Mon, 05 Sep 2022 07:48:29 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2C9A2DBF7 for ; Mon, 5 Sep 2022 07:48:29 +0200 (CEST) Received: from localhost ([::1]:47172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oV4yB-00028s-IV for larch@yhetil.org; Mon, 05 Sep 2022 01:48:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oV4vb-00028L-F5 for emacs-orgmode@gnu.org; Mon, 05 Sep 2022 01:45:47 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]:40584) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oV4vZ-0006RY-Mh for emacs-orgmode@gnu.org; Mon, 05 Sep 2022 01:45:47 -0400 Received: by mail-pg1-x52e.google.com with SMTP id b196so7216987pga.7 for ; Sun, 04 Sep 2022 22:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=kytMygwk6ZzDkpB66OFIBJC1uE59PKdtK0OUdrN25Yw=; b=qXHQn4aw9yZSxB4KVFAl7VZEptJfOFotaB6pLiQFVvam1DArsEz4WhOxSilHOL21I5 gINQKZyMX2gOFpDAjautm7qd7KWHmZtfNmGr7yhjHZAyFm474K8OlY0Uqoc921MS5luu AKDjdh/OTzbMd8NjERlI/TYFHp3U2RrIGFUdpIKZKCttOYTCd3IW2OErZF4qxz9OLZpb lDQC9zJ+lAWelqyCBxj3Z5iyNDB27E9zEaPcILnymTRbHyVtSYitf3fIZa71SjHX3B8N L0StySoBIR8RwCgYnlYRzaAEkBz8KxluR69P/ObWJzybclGt8vI4xn86FLSZD9wi+RIj ebuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=kytMygwk6ZzDkpB66OFIBJC1uE59PKdtK0OUdrN25Yw=; b=F38DX+5k167vwLBeJQWpvMwrJaS2+CtBsNbig2krgkUf/Eext41Tc9SWCvsOB89+Ar yvwk0fgNLx90yuxbSgBdii+LjhatZ8U2hWmlDpeEP/o9qCd+CIaPtHKQDxwoiavW1Gqr vewZClYmm7fcTQ1rEUSerFqAmXqSw0cobBlZw3ShvnCSUEzqZGII16jykkC/V+ZVe1bd y6gseUs2kQso9YGV/71UJIBm+DMHf/BQxTqEvMfKpe9z79U/2E/LlVoNRKIM/7FKyRYx GYkp/ial2OKIt8fWu6VNIw8jcvzsWQHkHxn8y+1lXjzWgCh2pQAoXb62sKxkwVwWp6vW fY6w== X-Gm-Message-State: ACgBeo1PGyJbTeRZxnEey8sJ/1W3FKa5vxCkpiNcGr7lwhiz5iFMrBOD Qy80CIT+T009zx9oSbNmeaY= X-Google-Smtp-Source: AA6agR6tq2KXntPtGmAnBp4FJSyh22XTiv8pU0KdCa+fEzA1YzofPl5+ZPcHmLRunymcdB4ljRWZaA== X-Received: by 2002:a62:27c1:0:b0:536:32d2:d098 with SMTP id n184-20020a6227c1000000b0053632d2d098mr48712944pfn.63.1662356744020; Sun, 04 Sep 2022 22:45:44 -0700 (PDT) Received: from localhost ([2409:8a70:2b2:5800:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id f9-20020a170902684900b00172f6726d8esm6390034pln.277.2022.09.04.22.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Sep 2022 22:45:43 -0700 (PDT) From: Ihor Radchenko To: Max Nikulin Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH v2] org.el: Fix percent substitutions in `org-open-file' In-Reply-To: References: <874kih92nb.fsf@kyleam.com> <87mtw8fupl.fsf@kyleam.com> <87tu5qm11q.fsf@localhost> <87o7vw983m.fsf@localhost> Date: Mon, 05 Sep 2022 13:46:41 +0800 Message-ID: <875yi2xtj2.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=yantar92@gmail.com; helo=mail-pg1-x52e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662356909; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kytMygwk6ZzDkpB66OFIBJC1uE59PKdtK0OUdrN25Yw=; b=issE513HvluliUNw1bE3LMlkRz504Ill8cvQ4t+4bXsWH4UHFB3TaaNeeznk/QKeemzM9A 8hpwTCHnQpwiYtq9k5FbP79Ny204t0O0tFvO5aEZPwvkNk+h/QGYIKSTFKFcbBmNuOryv9 v8cunr9PKuvxH+f3TmmFeqamC4TsHdc75mVv3Zy8w4/ZS6IdgIK3bU3ZogTCHf8cBMbUNF GPlGK0NR41u1b3qnt8Tai+G7BhAFSWpy8bUye2BlJ/OCv857TcgO6Opj+idz9Rp8gTw5ks GhDI5tmXAvibjSy2CojKgMsqVlzxomHxyLv5mgMz4slolPTyRWdihUL3R4kGJQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662356909; a=rsa-sha256; cv=none; b=jPlAZlSFplxZYfRh+1bPvLDfdoqLHUuobBKmy+drjoFWfgbyZAtPRXpOrl2mSIkhn+Nh/A P8YLjK+HA2HxM+N4ZOryKFFxQTqVdalSF9K4uyai1ENt73FjmJqkhIo2LAM4KHxBx4UC/a q3YJPp8pvtuPeUoC3tXKIwuOqdF3EofXXXN1iFq2jXsjGiK6aZTRs22E78KW2f2V3/ZYAs EU7GA52MzNCeJmCrGCklcL1JKz66JpRb4Tte39QFMNfiy5yM2NyXeWEKKNn5wv24Sakd0E tRgAY33hR4ILwZtaIeFqDV0/kAIC7ZiL8J6egUtpRyhR2+fX6QiYGBvipdnyeQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qXHQn4aw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.28 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qXHQn4aw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2C9A2DBF7 X-Spam-Score: -3.28 X-Migadu-Scanner: scn1.migadu.com X-TUID: fQPml/ky+7z+ Max Nikulin writes: > I have removed most parts of the example. In addition I fixed some > issues with references in the docstring (man mailcap is not recognized > as a link for some reason yet). I changed the function to consider > trailing backslash as a format error. Thanks! Applied onto main with minor amendments to punctuation in the docstrings. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=ac2d0a249e5419fb52bc1e953e70c847a31d40de > I mean another problem. A user adds (require 'some-package) that defines > new link type. Later the user invokes easy customization interface to > adjust a link unrelated to some-package. At this step > links from some-package are added to user's init file. Ideally it should > not happen and after removing of (require 'some-package) there should be > no link types from the package in the init file at all, including > customization section. > > From my point of view entries added to `org-link-parameters', > `org-file-apps', etc. by packages should not affect entries managed > through customization. Well. The situation with third-party packages overriding/changing defcustoms is not uncommon in Emacs. For example, display-buffer-alist is altered by shackle. I think that the usual approach to mitigate this problem (when it is a problem) is adding an auxiliary variable supplementing defcustom. Just like `org-entities' and `org-entities-user'. Note that we actually do have such auxiliary variables for `org-file-apps': `org-file-apps-macos', `org-file-apps-gnu', and `org-file-apps-windowsnt'. They are currently declared as constants, but we may change it - there is no strong reason to disallow altering those OS-specific variables. -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92