From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6OzzE2G8JWOGeQEAbAwnHQ (envelope-from ) for ; Sat, 17 Sep 2022 14:24:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kF2zE2G8JWPWZgAAauVa8A (envelope-from ) for ; Sat, 17 Sep 2022 14:24:01 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F02ADF34C for ; Sat, 17 Sep 2022 14:24:00 +0200 (CEST) Received: from localhost ([::1]:56044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZWrX-000068-QB for larch@yhetil.org; Sat, 17 Sep 2022 08:23:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZWqL-0008VG-8m for emacs-orgmode@gnu.org; Sat, 17 Sep 2022 08:22:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZWqK-0007Ox-Vv; Sat, 17 Sep 2022 08:22:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Ogw4Vz2wSRbOVGabt07wVWq99l3WFrI+TZF2NH4guQk=; b=If2iYnobe93sU0+64x2K EJ4NE8/4JQ/FdIraaDb47yUjZA5rbF43LBVHM+CU/t5Nv1h9dCRJpj6+1CAu55WtM04bjckAqcYwM 14tj1/Maq4qLQ6BlW8xlsK9BQyP1NZb62MOnbXoIy3EDu1EJpE0mfUALnVfIS4qt0VvLqo6C3lRBT A1b7cUV6kbVrIuLsGdHdpfKz4t5fFXopSeMXYy0cvKchcOa+YxzN3RS12I6imGCSmToSg3dFbFzvt njtOI8Pp5U5DDPRJc7wRRQ6ns1zuV3FfV1Xn7HM7fkUqIqgG5oVTa+2/63UsgfjrWx/yO9Fwmn5eu 3huYrqY4ag+1Qw==; Received: from 87.174.185.81.rev.sfr.net ([81.185.174.87]:37502 helo=hal) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZWqJ-0002Al-Uf; Sat, 17 Sep 2022 08:22:44 -0400 Received: by hal (Postfix, from userid 1000) id 06BA01E0413; Sat, 17 Sep 2022 14:22:42 +0200 (CEST) From: Bastien Guerry To: Ihor Radchenko Cc: Max Nikulin , emacs-orgmode@gnu.org Subject: Re: [PATCH] ol.el: Always prompt for description in `org-insert-link' In-Reply-To: <875yhoug5b.fsf@localhost> (Ihor Radchenko's message of "Fri, 16 Sep 2022 11:55:44 +0800") Organization: GNU References: <875yhoug5b.fsf@localhost> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Date: Sat, 17 Sep 2022 14:22:41 +0200 Message-ID: <875yhmyyum.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663417441; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Ogw4Vz2wSRbOVGabt07wVWq99l3WFrI+TZF2NH4guQk=; b=QB/E6z0QCIW5iCnbM+nwmAJFKMBoESStrCpSooEbV5R1fYsX0JlPvxli0aEha2SmJJ2Vtx zar6Nbe/yrir06/Q5zZ+bi7RBxkSfRDmY62V7WIK8wt859JkV4E3NJ8oo7ogpaGznwg4o+ gf8tEb+nnEt3ef4o94MGgyDtj832HV0qtXEgbNrCpGqpB/Yx/1uePCfn9w5mOPUnKRTp3U bMUsL4z+opDQ21bKw8fhUa0C65CwMwDhOcvrVuRoX7cnSXa1aJeCnCVQ8e3Zy2wtWnsiYt Fa/Iq8o8Ch9Y5zBbJX9LUG4Exmo4P6MGpUFN600hWOgN9oLR49hErmweOOAgDg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663417441; a=rsa-sha256; cv=none; b=pKx2KkqsMYC55M6luC641NdJg7JZqQVqBMOJwDGKvZM3FE2J1qwMol8BNcLylDnSpjpAej WrB1lPq1bvtQbWMTa8/Lq5X7Hlpd/cdE6m7WmrZFOf4EyNkuX4BdabZ5azfMJxQvWFmJZ7 kinFdogZKN/oUOs6zZaB5Kd4AUtXFrJp1qzlYivei00Fa3wp7lKzGWyyvKp+17jirq/kIA EH7dyd8Mtp9Men3wexisVNqDtr/CJXiDNiYOM5EXOJPzxZOZIzFO5SLJWtw5kH8bMbptB9 LOIoQgTcknn/aEodO89JiO3A1L7ubH+p0zQXL8S3wwN4m7bOYMa07ux/lKW1Jw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=If2iYnob; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.04 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=If2iYnob; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F02ADF34C X-Spam-Score: -5.04 X-Migadu-Scanner: scn1.migadu.com X-TUID: XTFaQykF/xiJ Ihor Radchenko writes: > Could you please check the ongoing changes in this area > (storing/inserting links)? The code in this area is old, confusing, and > not fully documented. I'm afraid that we may break something in the > process of refactoring. If you see some dangerous changes, please let us > know. Thanks for the heads up, I'll have a look this week. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=69b36beac790bad95fdd9ce4a7bcfbbb46d39c64 > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6d8d7fba61652434764c9906df69db373ff4f7f6 Are these changes the commits I should start from? If there are other important changes, let me know. Thanks, -- Bastien