From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ILxXJn0vxWORGgEAbAwnHQ (envelope-from ) for ; Mon, 16 Jan 2023 12:05:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YB1NJn0vxWPl9wAAauVa8A (envelope-from ) for ; Mon, 16 Jan 2023 12:05:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3A0A7A06D for ; Mon, 16 Jan 2023 12:05:33 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHNI8-00005e-Qg; Mon, 16 Jan 2023 06:04:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHNI7-00005V-Ew for emacs-orgmode@gnu.org; Mon, 16 Jan 2023 06:04:39 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHNI5-0003wn-Jp for emacs-orgmode@gnu.org; Mon, 16 Jan 2023 06:04:39 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E0BAF2401DE for ; Mon, 16 Jan 2023 12:04:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1673867074; bh=1ussQvyEmHmA9k9OokQEUhb7H9UbouFvVsNr9Qi/J0Y=; h=From:To:Cc:Subject:Date:From; b=Lo29EQNP8qPDbpjnIGDhRB507QIJWpvYinwYF+ENsKplj9kAUbUAj/GMTkMjgq5+1 zjsqM4Q6DD+miupu3HZz6EUaDlE8Xu+s7tr4lF1FQHCaDAviVXvjPjzAcVQhmfIAgW d+vLGB4yXSDVdrj/Moif1lz2OV7Wps/buVLyQWWdv5rclrq+m8S7fyiPBd8Mq+r3TL AsqO+eHkI888xont+wsbjMtNV990l6wSYqXey1dQ3FXOL+V6qcfLHOs26d5AG1YRRk JENgIE4sqJ2p09nIRYwtCGRskkOabvrIhj8SDz14Z7jZXh4nmLXXhx+CAec9xr3ABw x+iDweTrmH5gw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NwTgP2sSJz6tm9; Mon, 16 Jan 2023 12:04:32 +0100 (CET) From: Ihor Radchenko To: Daniel Kraus Cc: Andreas Gerler , emacs-orgmode@gnu.org Subject: Re: [BUG] ob-sql sql-connection-alist In-Reply-To: <878ri2bvsh.fsf@kraus.my> References: <87r0vuzs3w.fsf@localhost> <878ri2bvsh.fsf@kraus.my> Date: Mon, 16 Jan 2023 11:05:03 +0000 Message-ID: <875yd6n3j4.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673867133; a=rsa-sha256; cv=none; b=agoswpmrkRXxH3yrWAUJxxMNmZO3wmvHgTqD7n8j/5xyTohGX4LEJoTawHpYASaRm+GsAs ZTDQSIGK/ldri6wAI1sjCiYeydjl2w7antrHppf5TmQREmgH8LLzRaJr8PGwmXKkpn+DBy FGgbR7v55w6C+R/RCm0MV2VvA8lumxZOz4lxM6scHP+anGYA+si+1z2xsDyQZfAAtjkamL VrfobgYtqt0pF8DfVVOTdUaNkSH4d1Tl5/fIjE22fzwC/NPG3DYZoD2vZFr0OYg6SdZ2MZ aeczJMQEP9LRdFugzwslNKNmclDQqCNNOvbAucgjK6LjS/S7pCYzmf4irSbSOg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Lo29EQNP; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673867133; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=iWtcQEI6fs0lZnB9G5n0ogTq4m24br/zfzZK+5nXlM4=; b=ITWho+rRR5VrAmKMubgX0HXAyalWk0ePr+f/Grq8ROX4hI8SPOwJg6Hj9bVaC9IMeDQCIb 3pJVkCGdVlgpRQyGoPCAYsM6eDJctEw7Nj7pM1MKxw+Q12PPe6rL8vgIYKOO/5a8h3uQM7 i3a/zb9/E+3/0id0Na/LM88b7QBwfl6TPNa5u4AwnMTqPB4Ubfz602CAfdL6eP/GFG62BK wKdDTz1Y/1HzxNb1uifkSX+sOSps73WTleoX0+i5u8uYJrVkLKpww/Azdt3IT1zr7RaUR+ Hr4/+8Rkv3Hq01XWS9DFJOSUNFRlnUbYzQWBR0Pw18GdxgSAJvsnp0z6xK4aDA== X-Migadu-Spam-Score: -6.07 X-Spam-Score: -6.07 X-Migadu-Queue-Id: 3A0A7A06D X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Lo29EQNP; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: UpizPnIUFG91 Daniel Kraus writes: >> I am looking at the docstring of `sql-connection-alist': >> >> An alist of connection parameters for interacting with a SQL product. >> Each element of the alist is as follows: >> >> (CONNECTION \(SQL-VARIABLE VALUE) ...) >> >> Where CONNECTION is a case-insensitive string identifying the >> connection, ... >> >> So, your "setq" example is incorrect: must use "testdb" instead of >> `testdb' symbol. > > I'm not sure why but I also have the connection as a symbol in my > `sql-connection-alist`. > Looking in `sql.el` `(sql-connect)`, they also use > `assoc-string` to receive the connection: > https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/sql.el?h=ac2a6fc83fac6390892b068a830ebe0f22364e05#n4398 > > So I think that change is good and supports both formats > (same as `sql-connect`). Agree. In fact, I missed "insensitive" part of the docstring, reading it opposite. Andreas, feel free to send a proper patch with commit message. But please do not decrease the copyright years :) -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at