From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 0Nn0ENyBMmbnAgAAqHPOHw:P1 (envelope-from ) for ; Wed, 01 May 2024 19:54:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 0Nn0ENyBMmbnAgAAqHPOHw (envelope-from ) for ; Wed, 01 May 2024 19:54:36 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=T+TUJesY; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714586076; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/twxqMKAFMVlhHbDMAbYLCsFmYO+5xg0Kp8YypuMCrA=; b=ls8/HetPAzpaYV+oMpDyBYbO132cFioj7rqtXJYXVQuxbZXSZ+nGBwoSH0oHER9J2tC+Hq VnhWHgEHV6BdodYDXGfUZ2HH+KDtp/SyaHSbKQh2XvnhTJWoKpvZaUJUMYnHhjOqi0eFPv yIJCkbA2mZbbJ4kTn9Ex0a75EdwxC7TRmVUofiwfLIQzyYiCCXvaPOqsLEwcZ8u39WgE0L TZIaCxPT8uOSxqyTY/ndFzg6Putxf6kW5uhLGyPFuD59WgW1wb83STOXjgjFe/OKGw5ius ieyLUbbzmOGga8QA5AKRvaS7agm+3gI/R2f2eQp5YG199idRQ/9EVn3yypMCDw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=T+TUJesY; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714586076; a=rsa-sha256; cv=none; b=KZXsDglfwDccsyPmt/CTS6CcGcuOn3tKcyk3JzCsl8YSVSoKDNPLGPpBDiageecFGZbfNw o3r6Yym/P2itsqN8aglSUUci73y0zLjA5i2HPpNkivbpJGY/+jA7UgwtuCyE1QsE0loqdg XYd/p9f+2HsHFnkaTBPyYxeoSxMoWBBRmDQQoPzW52LpmDb8i1BMEZdVng/Anij9Jpnrw2 6dtue1jKrtPSafg97OM6RbQpAJMuw3a06UeqrcL+smEMy5gF7HY6NJ3QY5EWopeWdBqoEP vU8Tq0ZiVumXU5h/70L/jh06xFfHVLkkyZnoMyyJ4UBwcnCSPPQdCov8mvcrYg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D37C215A18 for ; Wed, 1 May 2024 19:54:35 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2E9Z-00083B-7o; Wed, 01 May 2024 13:54:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2E9W-00080B-LR for emacs-orgmode@gnu.org; Wed, 01 May 2024 13:53:58 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2E9U-0005eU-IU for emacs-orgmode@gnu.org; Wed, 01 May 2024 13:53:58 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9D431240027 for ; Wed, 1 May 2024 19:53:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1714586034; bh=HLgTBYAsH3H8ZzEKgh5OgPOAB98JIdsgd+c3Cib1A4E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=T+TUJesY6JFb81lS/gvuAoxOtq+5sYObpvccC25/jEp+4+mgQNW0Oxoqc45dCQn8y DEm4PrAcfQYcqquRfK1dcgIyQxkqbOmhc/AiJi8JsoyTICbBWIMueF7kvuu8te+G+4 PhBm7/0Hw9b4hHgxYZ5bsN3RoPAIiHRbE3HwKc4gcc8tVUUSEQUgLA3FBli+6pDORq sKVZeguY2iHnSApg29jZmQ6l8Nd/ESpLi8weSBZKGa28UEa2C6wNKzX1KGuRbyK39Z /VT916DkS8iud89QdhSLADc0XdaUKH9Ua2ZCDKlNHchHNQCRGPkAdmqkARBm1wsnIG PRI5Xjomlniqw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VV4SL0vlVz6tm4; Wed, 1 May 2024 19:53:54 +0200 (CEST) From: Ihor Radchenko To: Bruno Cardoso Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Add support for shortdoc link type In-Reply-To: <87wmodtqxt.fsf@gmail.com> References: <87zftatdkr.fsf@gmail.com> <87v83xer0d.fsf@localhost> <87wmodtqxt.fsf@gmail.com> Date: Wed, 01 May 2024 17:55:05 +0000 Message-ID: <875xvxs9hi.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.59 X-Spam-Score: -9.59 X-Migadu-Queue-Id: D37C215A18 X-Migadu-Scanner: mx13.migadu.com X-TUID: S7YnrzlJBxQ+ Bruno Cardoso writes: > Thanks for your comments. See attached the updated patch. Thanks for the update! > +- =shortdoc= :: > + > + Link to short documentation summary for a function group. Might be useful to throw a link to Emacs manual here - [[info:emacs#Name Help]] > +*** =ol.el=: Support for ~shortdoc~ link type > +Add support for storing and inserting links to ~shortdoc~ groups. =shortdoc= I think. It is not ~code~, but rather =verbatim=. > + (defun org-link--store-shortdoc (&optional _interactive?) > + (when (eq major-mode 'shortdoc-mode) > + (let* ((buffer (buffer-name)) > + (group (when (string-match "*Shortdoc \\(.*\\)\\*" buffer) > + (match-string 1 buffer)))) > + (when (assoc (intern group) shortdoc--groups) This will err when GROUP is nil (string-match does not match). > + (org-link-set-parameters "shortdoc" > + :follow #'org-link--open-shortdoc > + :store #'org-link--store-shortdoc)) Maybe also implement :complete parameter? It should be relatively easy. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at