From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id MIocGsRZO2b0tgAA62LTzQ:P1 (envelope-from ) for ; Wed, 08 May 2024 12:53:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id MIocGsRZO2b0tgAA62LTzQ (envelope-from ) for ; Wed, 08 May 2024 12:53:56 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Ae41gi2c; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715165636; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UqGftLEbmSkpFQ8F+FINCLnAi5mTuUhVTThha/R0aHw=; b=t8OBVbxd0Che3KaQrzi7QIoXx70cJ83vU7gsJaytMe3QSgp9LSlgAW2Tk6gyLKjAmNq0+D 3xpVQvZcT/2r2ZFHy/56fFOgdx6Y41KgVtgo9I+ntqhbGNF8sNy5zOTaSwwVymYyJ5/d15 SEz7v/F3biQ+fstlyRggpwaIvvg977q0j9FWGxOrAZWZWo4yrl4Vhty9TkufUF4g81cZei +XnvlPhauUTikTAaMsgjtm5FGlAThQmT6pUN3q6VFjXvYtGhdz7hGKotleIInROagm6i31 PSmbwnPgSIKlO+JSbjxh3a6cGQW0+XA39DrgD51ZSc6vjH0FJV6/XTrvIuSZ5Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Ae41gi2c; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715165636; a=rsa-sha256; cv=none; b=WS//Rr0LLkODobqyFkEhHvyqblAx+7f095k6c5Nde3ItZbUmbhW8AMmbwexPU3VD2Tx87T RcqdxA5WBmI7Ao43R4iGMH7l7P9z3Nnliz1lL0SQqCm491KZnhmGKxffPdCUOCqI6ruEBm fuHnXexIZRkO2Cj5opydi7lkgbWFBcNtrJXNpzKS2WyPBB/m9JaOqxf1yUlo7rZcUsM+6l PXcBjx7YqQ37SkO9s76B/cOlpK11X3b9G6W3sI2GEqb2vMDOtmB6HbUaO9Ln3oYRjlhM64 md15Bls25W4jW2BLwqz8EzWBxRfDoTrptjr3BtrEHMeru+SM3gqi0lu2HCbbJQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E3C152154A for ; Wed, 8 May 2024 12:53:54 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s4ev2-0000RH-Ev; Wed, 08 May 2024 06:53:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4eux-0000Qy-EB for emacs-orgmode@gnu.org; Wed, 08 May 2024 06:53:00 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4eut-0003Pu-Dz for emacs-orgmode@gnu.org; Wed, 08 May 2024 06:52:58 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 652DE240101 for ; Wed, 8 May 2024 12:52:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1715165571; bh=u2mCzIh8UPRWBeTzDsT+V81hSRt44QoUmjAbUatFdGU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=Ae41gi2co/wD4ID9w7HqvMK/sCizoZnOSE0bB1q4bBE7hYvF33mWEMb8oinVWD7U0 LZ00z/7jEcPfu/KpUFE/vP6Qk2GLlORR+qqiwI5sVgG+tORqwaI9gZ1JOiEkTOaI61 pE3zDrwl2SLRwJDRfZGrLyzVQn5dcBzyjBKpiU/5wSfkbZJhaOvFm5GbTmvK/f2Si8 gPMFsCM0VoUQuQGV8mRL1nDVp7t1boax0VkHX4c9eGxjOFxI6Ot8hNg27QWigrXL0K 50RkjlajNuWAOQuwsIue8RVFDcWJXEqVN9+2GAns+u5hym9ITnNYxZnmh17878w/Ld b3/tLYSzEHWlQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VZBnG2jtrz9rxF; Wed, 8 May 2024 12:52:50 +0200 (CEST) From: Ihor Radchenko To: Max Nikulin Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Fix regex for determining image width from attribute In-Reply-To: References: <87czmtuy0p.fsf@gmail.com> <8735noqig0.fsf@gmail.com> <87wnl05ag6.fsf@gmail.com> <87y25fq5d2.fsf@gmail.com> <8735nnlaef.fsf@gmail.com> <87v90jph1w.fsf@gmail.com> <871r37l96a.fsf@gmail.com> <87k0gzpb5s.fsf@gmail.com> <87h7c2pb6w.fsf@gmail.com> <87ee75pmsn.fsf@gmail.com> <87czmjajyx.fsf@gmail.com> <87k0grk0ge.fsf@gmail.com> <87ee6x3t39.fsf@gmail.com> <87zgpkq5a5.fsf@gmail.com> <871r2ucuhz.fsf@gmail.com> <87cyq49o01.fsf@localhost> Date: Wed, 08 May 2024 10:54:14 +0000 Message-ID: <875xvoshex.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -7.54 X-Migadu-Queue-Id: E3C152154A X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -7.54 X-TUID: uj0Ox4wGf2Qp Max Nikulin writes: >> 1. #+attr_org is prioritised > > I ma afraid, the code is a bit fragile. Consider > > #+attr_html: :alt Image width test > #+attr_beamer: :width \linewidth > #+attr_latex: :width +.5\textwidth > #+attr_md: :width 75% > [[file:babelfish.png]] > > - I do not mind that just "\linewidth" is ignored. > - The case of "+.5" should either be supported or at least documented > since it is a valid floating number. Was it supported before? > - It is really confusing that #+attr_html casts shadow on #+attr_md. No, it is not. I see no reason to prioritize markdown attributes. >> +++ b/etc/ORG-NEWS >> @@ -13,6 +13,18 @@ Please send Org bug reports to mailto:emacs-orgmode@gnu.org. > ... > > I think, it is better to avoid "is ignored" here. > > Previously, when ~org-image-actual-width~ is a list or nil, > Org used the first =#+attr_...= keyword containing =:width ...= > to compute the inline image width. > Now, =#+attr_org=, if present, takes precedence. > In the following example the image preview has width of 70% > while earlier versions take 33%. > > : #+attr_html: :width 33% > : #+attr_org: :width 0.7 > : [[image.png]] May you convert your suggestion into a patch? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at