From: Ihor Radchenko <yantar92@posteo.net>
To: Jack Kamm <jackkamm@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix ox-icalendar export of diary timestamps
Date: Sat, 21 Sep 2024 08:53:32 +0000 [thread overview]
Message-ID: <875xqppeur.fsf@localhost> (raw)
In-Reply-To: <87y13tqvpd.fsf@gmail.com>
Jack Kamm <jackkamm@gmail.com> writes:
> ox-icalendar skips the following event with a diary timestamp during
> export:
>
> * First Sunday of the month
> <%%(diary-float t 0 1)>
>
> ox-icalendar actually has longstanding code to handle diary timestamps
> [1], but that code path is not reached, in part because
> `org-export--skip-p' always skips timestamps with type `diary'.
>
> The attached patch fixes this by including diary timestamps when the
> export option `:with-timestamps' is `active'. I think it's reasonable
> to consider diary timestamps as a type of active timestamp during
> export, since they are included in the agenda, and have angle
> brackets.
I agree that it makes sense.
However, it is technically a breaking change.
May you please add a news entry as well?
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2024-09-21 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-15 6:26 [PATCH] Fix ox-icalendar export of diary timestamps Jack Kamm
2024-09-21 8:53 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xqppeur.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=jackkamm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).