From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] org-macs: store evaluated version of pom Date: Sun, 27 Feb 2011 12:46:20 +0100 Message-ID: <874o7pr6hy.fsf@altern.org> References: <1298640633-17072-1-git-send-email-julien@danjou.info> <87hbbqaet6.fsf@gnu.org> <87k4gmek7c.fsf@keller.adm.naquadah.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from [140.186.70.92] (port=37385 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ptg04-0001va-E0 for emacs-orgmode@gnu.org; Sun, 27 Feb 2011 07:45:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ptfzz-0008Ht-Bw for emacs-orgmode@gnu.org; Sun, 27 Feb 2011 07:45:24 -0500 Received: from mail-fx0-f41.google.com ([209.85.161.41]:54623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ptfzz-0008He-6d for emacs-orgmode@gnu.org; Sun, 27 Feb 2011 07:45:19 -0500 Received: by fxm5 with SMTP id 5so3518728fxm.0 for ; Sun, 27 Feb 2011 04:45:18 -0800 (PST) In-Reply-To: <87k4gmek7c.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Sat, 26 Feb 2011 19:15:19 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hi Julien, Julien Danjou writes: > Yes it is. This patch just fix one problem. Without it, what is set > with pom is evaluated multiple times: > > (org-with-point-at (function-that-return-some-marker) > (do-stuff)) > > (function-that-return-some-marker) will be called several times, which > can causes a lot of problem, as you imagine just by reading the current > code. > > This patch evalute the function, store it to `pom' and use this variable > instead. Many thanks for the explanations. I've now applied this patch. -- Bastien