From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: [babel][patch] BUG in inline source blocks Date: Mon, 30 Jan 2012 09:06:15 -0700 Message-ID: <874nvd18g8.fsf@gmx.com> References: <87fwf27w67.fsf@med.uni-goettingen.de> <87y5ss6aul.fsf@med.uni-goettingen.de> <87aa58aeyn.fsf@gmx.com> <87mx985g7b.fsf@med.uni-goettingen.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:50380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rrtki-0002Xo-AZ for emacs-orgmode@gnu.org; Mon, 30 Jan 2012 11:06:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RrtkZ-0001kZ-5R for emacs-orgmode@gnu.org; Mon, 30 Jan 2012 11:06:44 -0500 Received: from mailout-us.gmx.com ([74.208.5.67]:52008) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1RrtkY-0001kQ-Pa for emacs-orgmode@gnu.org; Mon, 30 Jan 2012 11:06:35 -0500 In-Reply-To: (Martyn Jago's message of "Sun, 29 Jan 2012 00:34:50 +0000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Martyn Jago Cc: emacs-orgmode@gnu.org > > Thanks. But out of interest why were the tests discarded? They are after > all the proof that the code works, and the `living specification' of > expected behavior. > > Just wondering > My apologies, I didn't see the tests when looking at your patch and didn't realize they were there. Thanks for mentioning this, I have now applied them. BTW: the only reason I didn't apply your patch outright was because by the time I got to your message in the thread I had already pushed up my own (less comprehensive) patch which conflicted with your own. Also, as a more general note to everyone who works with and submits patches. It is worthwhile to review the text of a patch before submitting because often trivial things like changed indentation can add many lines to a patch file hiding the actual code changes. Cheers, -- Eric Schulte http://cs.unm.edu/~eschulte/