emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Eric Schulte <eric.schulte@gmx.com>
To: Martyn Jago <martyn.jago@btinternet.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [babel][patch] BUG in inline source blocks
Date: Mon, 30 Jan 2012 09:06:15 -0700	[thread overview]
Message-ID: <874nvd18g8.fsf@gmx.com> (raw)
In-Reply-To: <m2hazf1h3p.fsf@btinternet.com> (Martyn Jago's message of "Sun, 29 Jan 2012 00:34:50 +0000")

>
> Thanks. But out of interest why were the tests discarded? They are after
> all the proof that the code works, and the `living specification' of
> expected behavior.
>
> Just wondering 
>

My apologies,

I didn't see the tests when looking at your patch and didn't realize
they were there.  Thanks for mentioning this, I have now applied them.

BTW: the only reason I didn't apply your patch outright was because by
the time I got to your message in the thread I had already pushed up my
own (less comprehensive) patch which conflicted with your own.

Also, as a more general note to everyone who works with and submits
patches.  It is worthwhile to review the text of a patch before
submitting because often trivial things like changed indentation can add
many lines to a patch file hiding the actual code changes.

Cheers,

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

      reply	other threads:[~2012-01-30 16:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-26  7:36 [babel] BUG in inline source blocks Andreas Leha
2012-01-26 13:29 ` [babel][patch] " Martyn Jago
2012-01-26 19:55   ` Martyn Jago
2012-01-27 22:26     ` Andreas Leha
2012-01-27 23:33       ` Eric Schulte
2012-01-28  9:28         ` Andreas Leha
2012-01-29  0:34           ` Martyn Jago
2012-01-30 16:06             ` Eric Schulte [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874nvd18g8.fsf@gmx.com \
    --to=eric.schulte@gmx.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=martyn.jago@btinternet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).