emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: Sebastien Vauban <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-program-exists vs executable-find
Date: Wed, 18 Apr 2012 15:25:45 +0200	[thread overview]
Message-ID: <874nshjhnq.fsf@altern.org> (raw)
In-Reply-To: <80mx69us0v.fsf@somewhere.org> (Sebastien Vauban's message of "Wed, 18 Apr 2012 14:46:24 +0200")

Hi Sébastien,

"Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:

> While browsing the Org code, I've found the function `org-program-exists':
>
> #+begin_src emacs-lisp
>   (defun org-program-exists (program-name)
>     "Checks whenever we can locate program and launch it."
>     (if (member system-type '(gnu/linux darwin))
>         (= 0 (call-process "which" nil nil nil program-name))))
> #+end_src
>
> It is used 3 times in `org-clock.el', nowhere else.

The name `org-program-exists' is actually misleading, it should be
`org-executable-call' instead, while still checking if the executable
exists before calling it.

> On the contrary, `executable-find' is used 10 times in the Org code base (in
> 4 different libraries).
>
> Shouldn't we better use `executable-find' everywhere, instead of
> `org-program-exists' (which, btw, fails on Windows systems, even when they
> have the Cygwin `which' at their disposal)?
>
> I'm ready to submit a patch for this.

Please submit a patch using `executable-find' in `org-executable-call'.
̀executable-find' takes care of (gnu/linux|darwin-windows).  Also add an
alias org-program-exists -> org-executable-call in case people are using 
org-program-exists in their programs.

Thanks!

-- 
 Bastien

  reply	other threads:[~2012-04-18 13:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-18 12:46 org-program-exists vs executable-find Sebastien Vauban
2012-04-18 13:25 ` Bastien [this message]
2012-04-18 14:39   ` Sebastien Vauban
2012-04-20 11:22     ` Bastien
2012-04-20 20:24       ` Sebastien Vauban
2012-04-20 20:42         ` Martyn Jago
2012-04-21 10:13         ` Achim Gratz
2012-04-28 21:44         ` Bastien
2012-06-14 13:05         ` Giovanni Ridolfi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874nshjhnq.fsf@altern.org \
    --to=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=wxhgmqzgwmuf@spammotel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).