emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: emacs-orgmode@gnu.org
Subject: Re: bug#11249: 24.1.50; Overlay with face property causes	calendar buffer to scroll
Date: Sun, 22 Apr 2012 08:46:03 +0200	[thread overview]
Message-ID: <874nsctgb8.fsf@gnu.org> (raw)
In-Reply-To: <20120421193406.GA1111@c3po.home> (Toby Cubitt's message of "Sat, 21 Apr 2012 21:34:06 +0200")

Toby Cubitt <tsc25@cantab.net> writes:

> Thanks for the fix. I notice that the new face's dosctring still says
> "Face for deadlines and TODO keywords", which needs changing.

Fixed, thanks.

> Was there some reason to reject Eli's suggested fix of enlarging the
> calendar window by 1 line? As it stands, if anyone customizes the new
> org-date-selected face to be bold (the highlighted date *is* a little
> less visible now), it will cause the same problem as before. And the fact
> that it's caused by making the font bold is not at all obvious...at
> least, it wasn't obvious to me! Eli's fix works more generally.

This general solution comes with a cost -- enlarging the window by
one-line for everyone just because a few users will use bold fonts and 
have a problem while displaying... does not feel right to me.

> Anyway, since I now know how to patch things if I do decide I want a bold
> font, it's not a big issue for me.
>
> In the patch I posted, I also took the opportunity to set `cursor-type'
> to nil when opening the calendar in `org-read-date'. The cursor obscures
> one digit of the selected date, making that bit harder to read (as well
> as looking ugly). Did you intend to reject this change too?

I did because I found the not-bold-anymore face wasn't visible enough,
and the shallow cursor made it visible.

I use inverse-video now for this face, so cursor-type nil is okay, 
I applied a patch with this.

-- 
 Bastien

  reply	other threads:[~2012-04-22  6:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <83zkaczq1v.fsf@gnu.org>
2012-04-15 21:04 ` bug#11249: 24.1.50; Overlay with face property causes calendar buffer to scroll Toby Cubitt
2012-04-16  2:50   ` Eli Zaretskii
2012-04-16 13:41     ` Toby Cubitt
2012-04-20 11:57       ` Bastien
2012-04-21 19:34         ` Toby Cubitt
2012-04-22  6:46           ` Bastien [this message]
2012-04-22 10:05             ` Toby Cubitt
2012-04-25 21:30             ` Matt Lundin
2012-04-25 23:10               ` Matt Lundin
2012-04-26  8:59                 ` Bastien
2012-04-26 13:19                   ` Toby Cubitt
2012-04-26 13:43                     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874nsctgb8.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).