From: Max Mikhanosha <max@openchat.com>
To: Bastien <bzg@altern.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] speedup redisplay of agenda item after change
Date: Sun, 30 Sep 2012 16:29:05 -0400 [thread overview]
Message-ID: <874nmftfu6.wl%max@openchat.com> (raw)
In-Reply-To: <87wqzds5oy.fsf@bzg.ath.cx>
At Sat, 29 Sep 2012 08:21:08 +0200,
Bastien wrote:
>
> Max Mikhanosha <max@openchat.com> writes:
>
> > Following patch changes (org-agenda-change-all-lines) to call
> > (org-agenda-finalize) for each line changed, with agenda buffer
> > narrowed to just that line, and it speeds up redisplay of current item
> > a lot, the Shift-Up changing of priority can almost keep up with
> > keyboard repeat rate on large agendas.
>
> This is a great optimization trick, thanks a lot for this patch,
> I just applied it.
>
> > I was running with this patch for a month, and did not noticed any
> > problems so far.
>
> Did you run it with latest Org from maint, from master?
No sorry I had not tried with maint, just with head of the repository.
> Also, would you like to get push access to the repo? I'd be glad.
> Just send me your public key if so.
I've had commit access (for sticky agenda), so unless someone removed
me I should still have it.
The reason I did not commit it directly, that its kind of innocent
looking change but in the sensitive area of the code, so I wanted more
eyes / testing on it first. If there is anything broken by it, my
guess it could bulk commands, clocking and/or undo stuff, and I'm not
these much.
Regards,
Max
next prev parent reply other threads:[~2012-09-30 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 17:01 [PATCH] speedup redisplay of agenda item after change Max Mikhanosha
2012-09-29 6:21 ` Bastien
2012-09-30 20:29 ` Max Mikhanosha [this message]
2012-09-30 21:20 ` Bastien
2012-09-29 9:20 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nmftfu6.wl%max@openchat.com \
--to=max@openchat.com \
--cc=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).