From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: babel perl issue Date: Tue, 11 Dec 2012 19:31:13 +0100 Message-ID: <874njszbim.fsf@Rainer.invalid> References: <87a9tntr29.fsf@Rainer.invalid> <87sj7fp7om.fsf@gmail.com> <87wqwrrml2.fsf@Rainer.invalid> <87vcca9bxw.fsf@gmail.com> <87d2yhvm3c.fsf@Rainer.invalid> <87obi193mn.fsf@gmail.com> <87zk1lu53s.fsf@Rainer.invalid> <87zk1kmpyo.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:59550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiUc5-0007f8-P4 for emacs-orgmode@gnu.org; Tue, 11 Dec 2012 13:31:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TiUc4-0005PC-Cl for emacs-orgmode@gnu.org; Tue, 11 Dec 2012 13:31:29 -0500 Received: from plane.gmane.org ([80.91.229.3]:39960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiUc4-0005Ov-6R for emacs-orgmode@gnu.org; Tue, 11 Dec 2012 13:31:28 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1TiUcC-0006O1-B3 for emacs-orgmode@gnu.org; Tue, 11 Dec 2012 19:31:36 +0100 Received: from pd9eb2efa.dip.t-dialin.net ([217.235.46.250]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 11 Dec 2012 19:31:36 +0100 Received: from Stromeko by pd9eb2efa.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 11 Dec 2012 19:31:36 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Eric Schulte writes: > I'm attaching two patches which implement this new require structure. > They move ob.el -> ob-core.el. The new ob.el (which is now loaded by > every file which requires 'ob) does two things. That looks OK so far, just one nit: it would be much cleaner from the perspective of Git if you first renamed ob.el -> ob-core.el and then patched it. That way git blame would continue to work across that commit in a mostly sensible manner. Right now all lines in those two files are new things that sprang into existence with this commit as far as Git is concerned. > 1. It defines every Babel defcustom (excluding the language-specific > defcustoms). Should defvars be moved here as well? Not necessarily, but if it cleans up the code, this would be worth doing. Maybe as a second step, since none of it should be broken right now? > 2. It loads the remainder of Babel, namely; ob-eval, ob-core, ob-comint, > ob-exp, ob-keys, ob-table, ob-lob, ob-ref and ob-tangle. Which codepaths would directly activate ob-comint for instance and why is it appropriate to just (require 'ob-core) in this case? > This allows for most of the language files to be simplified as they now > only need to require ob, rather than requiring the subset of the above > particular to their needs. Looks nicer to me, anyway. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada