From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: [PATCH] Do not indent option keywords Date: Fri, 10 May 2013 08:39:30 +0200 Message-ID: <874nebfie5.fsf@Rainer.invalid> References: <8738twge3b.fsf@Rainer.invalid> <87txmbgaeg.fsf@Rainer.invalid> <41207E77-189F-40AB-909D-3581EFA38288@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:35601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UahE7-00015M-CG for emacs-orgmode@gnu.org; Fri, 10 May 2013 02:54:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UahE6-0006pu-5M for emacs-orgmode@gnu.org; Fri, 10 May 2013 02:54:47 -0400 Received: from plane.gmane.org ([80.91.229.3]:39543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UahE5-0006pq-V6 for emacs-orgmode@gnu.org; Fri, 10 May 2013 02:54:46 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UagzW-0000z6-0E for emacs-orgmode@gnu.org; Fri, 10 May 2013 08:39:42 +0200 Received: from pd9eb279c.dip0.t-ipconnect.de ([217.235.39.156]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 10 May 2013 08:39:41 +0200 Received: from Stromeko by pd9eb279c.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 10 May 2013 08:39:41 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Carsten Dominik writes: > by decoration you mean font-lock support? Yes, but I also don't think these should ever become indented in the first place. That's debatable of course, the syntax as defined by org-element does not require this IIRC. > Maybe this would be a better fix: > > Modified lisp/org.el > diff --git a/lisp/org.el b/lisp/org.el > index 745fb82..43df094 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -5867,7 +5867,8 @@ by a #." > ((or (equal dc1 "+results") > (member dc1 '("+begin:" "+end:" "+caption:" "+label:" > "+orgtbl:" "+tblfm:" "+tblname:" "+results:" > - "+call:" "+header:" "+headers:" "+name:")) > + "+call:" "+header:" "+headers:" "+name:" > + "+options:")) > (and (match-end 4) (equal dc3 "+attr"))) > (add-text-properties > beg (match-end 0) Sure, that helps too and has certainly less potential for controversy. I think we should make an effort to shift most if not all the regex stuff in org.el into org-element. There's far too much duplication with subtle differences sprinkled all over the place to get match data to work with and it's almost hopeless to try and find all such uses for a single element. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles for Waldorf rackAttack: http://Synth.Stromeko.net/Downloads.html#WaldorfSounds