emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: [RFC] Change some defcustoms into defcont
Date: Mon, 21 Oct 2013 17:15:27 +0200	[thread overview]
Message-ID: <874n8avenk.fsf@gmail.com> (raw)
In-Reply-To: <7839A647-8D17-47A9-A65D-5FD7110ED082@gmail.com> (Carsten Dominik's message of "Mon, 21 Oct 2013 13:56:10 +0200")

Carsten Dominik <carsten.dominik@gmail.com> writes:

> The documentation of defconst says:
>
>> Define SYMBOL as a constant variable.
>> This declares that neither programs nor users should ever change the
>> value.  This constancy is not actually enforced by Emacs Lisp, but
>> SYMBOL is marked as a special variable so that it is never lexically
>> bound.
>
> So it is pretty clear about the intent of such a definition, which is
> to never change it - even though it does not enforce it.

I must have been clear as mud, because that's exactly what I'm
suggesting since the beginning of this thread: set "DEADLINE" and al. in
stone, and never change them again.

I have been pointing out, though, that it would not break previous
changes if they were done with `setq', according to how defconst are
handled. But I never intended to make it a feature, nor did I suggest
that was desirable.

> As you have said, we still want to allow users in principle to change
> these variables.

No, I haven't said such a thing. I said, verbatim, "In principle, they
mustn't be changed", which means quite the contrary.

> They have been defcustoms in the past, some people will have changed
> them. Their setup will break when they switch to a new version.

Indeed. But that's easy to fix programmatically.

> That is why I object to changing their status. I think it causes
> unnecessary breakage, and we can prevent this by keeping them
> defcustom. Nothing is really gained by changing their status.

It fixes at least a bug, prevents headaches by simplifying maintenance,
makes Org syntax more portable and more cache friendly. I wouldn't call
that "nothing".

Anyway, I have well understood that you don't want to change their
status. So be it.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2013-10-21 15:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-20  8:47 [RFC] Change some defcustoms into defcont Nicolas Goaziou
2013-10-20 18:23 ` Carsten Dominik
2013-10-21  8:56   ` Nicolas Goaziou
2013-10-21 10:26     ` Carsten Dominik
2013-10-21 10:51       ` Nicolas Goaziou
2013-10-21 11:56         ` Carsten Dominik
2013-10-21 15:15           ` Nicolas Goaziou [this message]
2013-10-22  7:50             ` Carsten Dominik
2013-10-22  9:52               ` Nicolas Goaziou
2013-10-22 10:34                 ` Carsten Dominik
2013-10-22 18:28                   ` Torsten Wagner
2013-10-22 20:00                     ` Florian Beck
2013-10-23  8:56                   ` Nicolas Goaziou
2013-10-23 13:25                     ` Carsten Dominik
2013-10-29 14:04                       ` Nicolas Goaziou
2013-10-29 14:11                         ` Nicolas Goaziou
2013-11-16 20:25                       ` Nicolas Goaziou
2013-11-16 23:55                         ` Carsten Dominik
2013-10-21  8:17 ` Sebastien Vauban

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874n8avenk.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).