From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: [babel][PATCHES] ob-R patches for review Date: Fri, 09 May 2014 08:34:37 -0600 Message-ID: <874n0zhvgi.fsf@gmail.com> References: <87ppjpm5n5.fsf@gmail.com> <8F4A9158-D8BD-4FE7-8D9A-A22C4871BDB6@gmail.com> <87ppjnt88e.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiltB-0006iv-1M for emacs-orgmode@gnu.org; Fri, 09 May 2014 10:35:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wilt6-0001Rb-N6 for emacs-orgmode@gnu.org; Fri, 09 May 2014 10:35:04 -0400 In-Reply-To: (Rainer M. Krug's message of "Fri, 09 May 2014 15:45:09 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rainer M Krug Cc: Bastien , "emacs-orgmode@gnu.org" , Rainer M Krug Rainer M Krug writes: > Bastien writes: > >> Hi Rainer, >> >> Rainer M Krug writes: >> >>> I'll look at it again tomorrow and let you know as I made some changes >>> since then. Do you prefer one patch to several? >> >> Up to Eric's taste -- but in general I think a series of patches >> is better, it allows you to isolate and fix conflicts more easily. > I agree, multiple patches make future maintenance easier. >> I missed some previous discussion in this thread. Are these patches >> ready to be applied as is? >> > > > IMO, the patches hard coded behaviors that would better be customizable > and optional. > > Rainer and I had some back and forth about this -- see the thread. With respect to these points, I'm inclined to agree with Charles in the following. > All you have to do is add this: > > (defvar org-babel-R-assign-elisp-function 'org-babel-R-assign-elisp > "Name or definition of function to handle `:var name=value' > header args." > ) > > and change one line in org-babel-variable-assignments:R from > > (org-babel-R-assign-elisp to > > (funcall org-babel-R-assign-elisp-function > > and the user can provide her own elisp assignment function. > > This gives users who want special behavior like creating something > other than a data.frame the option of providing their own function. Would such a customization variable be difficult to add to your patches? If not would you mind submitting a version of the patches split into multiple commits with as much of the hard-coded R code as feasible placed into customizable variables along the lines of the `org-babel-R-assign-elisp-function' variable suggested by Charles. One lesson I've certainly learned from the Org-mode mailing list is that you can't anticipate all of the ways that your code will be used, so up-front customizability generally pays off. Thanks, Eric > > Thanks > > Rainer -- Eric Schulte https://cs.unm.edu/~eschulte PGP: 0x614CA05D