From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: [PATCH] ox-taskjuggler.el: allow direct 'depends' specification Date: Thu, 12 Nov 2015 17:36:43 +0100 Message-ID: <874mgrkwdg.fsf@gmx.us> References: <87vb9akcwc.fsf@feelingofgreen.ru> <87egfysorn.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwus0-0001Md-3R for emacs-orgmode@gnu.org; Thu, 12 Nov 2015 11:37:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zwuru-0000Rb-G5 for emacs-orgmode@gnu.org; Thu, 12 Nov 2015 11:37:07 -0500 Received: from plane.gmane.org ([80.91.229.3]:55919) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwuru-0000R9-AE for emacs-orgmode@gnu.org; Thu, 12 Nov 2015 11:37:02 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Zwurq-0007Xp-7D for emacs-orgmode@gnu.org; Thu, 12 Nov 2015 17:36:58 +0100 Received: from 62.80.108.11 ([62.80.108.11]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 12 Nov 2015 17:36:58 +0100 Received: from rasmus by 62.80.108.11 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 12 Nov 2015 17:36:58 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Aaron Ecay writes: > Hi Kosyrev, > > 2015ko azaroak 8an, Kosyrev Serge-ek idatzi zuen: >> >> * ox-taskjuggler.el (org-taskjuggler-valid-task-attributes): add depends >> to the list of valid task attributes >> --- >> contrib/lisp/ox-taskjuggler.el | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/contrib/lisp/ox-taskjuggler.el b/contrib/lisp/ox-taskjuggler.el >> index 2bd47e6..cfb28f2 100644 >> --- a/contrib/lisp/ox-taskjuggler.el >> +++ b/contrib/lisp/ox-taskjuggler.el >> @@ -301,7 +301,7 @@ but before any resource and task declarations." >> :type '(string :tag "Preamble")) >> >> (defcustom org-taskjuggler-valid-task-attributes > > Is this an open-ended list that an average user could meaningfully add > to? If not, perhaps it should be a defconst. (I don’t know anything > about the taskjuggler format, so I’m sure whatever decision you make > will be OK.) Would a user be able to meaningfully add something to the list? Or does each attribute need some lisp glue to be transformed from Org to the taskjuggler format? In case of the latter, it should be a defvar IMO. Also, as suggested by Aaron it would be great if you could add pointers to the taskjuggler documentation. Thanks, Rasmus -- History is what should never happen again