Re: [PATCH] ox-taskjuggler.el: allow direct 'depends' specification

[Rasmus <rasmus@gmx.us>]

Aaron Ecay <aaronecay@gmail.com> writes:

> Hi Kosyrev,
>
> 2015ko azaroak 8an, Kosyrev Serge-ek idatzi zuen:
>> 
>> * ox-taskjuggler.el (org-taskjuggler-valid-task-attributes): add depends
>> to the list of valid task attributes
>> ---
>>  contrib/lisp/ox-taskjuggler.el | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/contrib/lisp/ox-taskjuggler.el b/contrib/lisp/ox-taskjuggler.el
>> index 2bd47e6..cfb28f2 100644
>> --- a/contrib/lisp/ox-taskjuggler.el
>> +++ b/contrib/lisp/ox-taskjuggler.el
>> @@ -301,7 +301,7 @@ but before any resource and task declarations."
>>    :type '(string :tag "Preamble"))
>>  
>>  (defcustom org-taskjuggler-valid-task-attributes
>
> Is this an open-ended list that an average user could meaningfully add
> to?  If not, perhaps it should be a defconst.  (I don’t know anything
> about the taskjuggler format, so I’m sure whatever decision you make
> will be OK.)

Would a user be able to meaningfully add something to the list?  Or does
each attribute need some lisp glue to be transformed from Org to the
taskjuggler format?  In case of the latter, it should be a defvar IMO.

Also, as suggested by Aaron it would be great if you could add pointers to
the taskjuggler documentation.

Thanks,
Rasmus

-- 
History is what should never happen again