From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] : org-link-search failing to find links created by clock table Date: Mon, 17 Apr 2017 10:07:03 +0200 Message-ID: <874lxno3tk.fsf@nicolasgoaziou.fr> References: <0C9625C0-3F43-4C6C-AA28-06D1102ACA10@oracle.com> <5B39C288-EC11-4B62-85AB-4267AE93AD0A@oracle.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d01gk-0001lH-LP for emacs-orgmode@gnu.org; Mon, 17 Apr 2017 04:07:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d01gh-0007Gg-Fq for emacs-orgmode@gnu.org; Mon, 17 Apr 2017 04:07:10 -0400 Received: from relay7-d.mail.gandi.net ([2001:4b98:c:538::200]:44776) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d01gh-0007GL-77 for emacs-orgmode@gnu.org; Mon, 17 Apr 2017 04:07:07 -0400 In-Reply-To: <5B39C288-EC11-4B62-85AB-4267AE93AD0A@oracle.com> (Stacey Marshall's message of "Sat, 15 Apr 2017 15:48:35 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Stacey Marshall Cc: Org Mode Hello, "Stacey Marshall" writes: > Sorry, I'm trying out MailMate and forgot to select Plain Text when > copying in from Emacs. > > * Example of the issue > > Emacs : GNU Emacs 25.2.1 (x86_64-apple-darwin16.4.0, Carbon Version 157 > AppKit 1504.81) > of 2017-03-07 > Package: Org mode version 9.0.5 (release_9.0.5-351-g0e0fda.dirty @ > /Users/stacey/.emacs.d/org-mode/lisp/) > > In this buffer the TODO keywords are FIXME and FIXED, as set by: > > #+SEQ_TODO: FIXME FIXED > > #+BEGIN: clocktable :maxlevel 4 :scope subtree :link t > #+CAPTION: Clock summary at [2017-04-14 Fri 20:01] > > | Headline > | Time | | | | > |----------------------------------------------------------------------------------------------------------------+-----------+---------+---+---| > | *Total time* > | *1h 9min* | | | | > |----------------------------------------------------------------------------------------------------------------+-----------+---------+---+---| > | [[file:/tmp/test.org::Example%20of%20the%20issue][Example of the > issue]] | 1h 9min | | > | | > | \_ [[file:/tmp/test.org::Test%20log][Test log]] > | | 0h 4min | | | > | \_ [[file:/tmp/test.org::Test%20log][FIXME Test log]] > | | 1h 0min | | | > | \_ [[file:/tmp/test.org::test%20with%20comment%20no%20to-do][COMMENT > test with comment no to-do]] | | 0h 2min | | | > | \_ > [[file:/tmp/test.org::FIXME%20comment%20with%20to-do%20keyword][COMMENT > FIXME comment with to-do keyword]] | | 0h 1min | | | > | \_ [[file:/tmp/test.org::with%20a%20fraction][FIXME with a fraction]] > | | 0h 1min | | | > | \_ [[file:/tmp/test.org::with%20a%20percentage][FIXME with a > percentage]] | | 0h 1min | > | | > #+END: > > ** Test log > :LOGBOOK: > CLOCK: [2017-04-11 Tue 23:20]--[2017-04-11 Tue 23:24] => 0:04 > :END: > ** FIXME Test log > :LOGBOOK: > CLOCK: [2017-04-11 Tue 22:20]--[2017-04-11 Tue 23:20] => 1:00 > :END: > > ** COMMENT test with comment no to-do > :LOGBOOK: > CLOCK: [2017-04-14 Fri 17:29]--[2017-04-14 Fri 17:31] => 0:02 > :END: > ** COMMENT FIXME comment with to-do keyword > :LOGBOOK: > CLOCK: [2017-04-14 Fri 17:31]--[2017-04-14 Fri 17:32] => 0:01 > :END: > ** FIXME with a fraction [1/2] > :LOGBOOK: > CLOCK: [2017-04-14 Fri 17:42]--[2017-04-14 Fri 17:43] => 0:01 > :END: > - [X] One > - [ ] two > ** FIXME with a percentage [50%] > :LOGBOOK: > CLOCK: [2017-04-14 Fri 17:32]--[2017-04-14 Fri 17:33] => 0:01 > :END: > - [ ] one > - [X] two > > > * Patch > > Appears that change ebbc675bd9890c451ad01910fa2625fa78baac9b way back > in 9.0.1 needed to also modify org-clock.el, or at least when I revert > that change I get the behavior I'm used to back. > > Below is a patch which modifies org-clock.el; Though I'm sure it can > be approved upon. Thank you for the analysis and the patch. I incorporated your suggestion in a larger patch since there were other fishy parts in the function. It is now hopefully fixed. Regards, -- Nicolas Goaziou