emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Add missing require in org-test.el
@ 2017-07-14 13:51 Stig Brautaset
  2017-07-14 17:21 ` Nicolas Goaziou
  0 siblings, 1 reply; 3+ messages in thread
From: Stig Brautaset @ 2017-07-14 13:51 UTC (permalink / raw)
  To: Org Mode

[-- Attachment #1: Type: text/plain, Size: 93 bytes --]


This is required for me to be able to run tests on master with GNU Emacs
26.0.50 on macOS.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Add missing require to be able to run tests --]
[-- Type: text/x-patch, Size: 699 bytes --]

From f8959cd59e1f9ba5b6752d3d76f042c89553c7a3 Mon Sep 17 00:00:00 2001
From: Stig Brautaset <stig@brautaset.org>
Date: Fri, 14 Jul 2017 14:48:37 +0100
Subject: [PATCH] org-test: add missing require for cl.el

---
 testing/org-test.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testing/org-test.el b/testing/org-test.el
index 844178e5a..7897e07e5 100644
--- a/testing/org-test.el
+++ b/testing/org-test.el
@@ -58,6 +58,7 @@
 			   (cons (expand-file-name "jump" org-test-dir)
 				 load-path))))
       (require 'cl-lib)
+      (require 'cl)
       (require 'ert)
       (require 'ert-x)
       (when (file-exists-p (expand-file-name "jump/jump.el" org-test-dir))
-- 
2.11.0 (Apple Git-81)


[-- Attachment #3: Type: text/plain, Size: 6 bytes --]


Stig

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Add missing require in org-test.el
  2017-07-14 13:51 [PATCH] Add missing require in org-test.el Stig Brautaset
@ 2017-07-14 17:21 ` Nicolas Goaziou
  2017-07-14 19:26   ` Stig Brautaset
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2017-07-14 17:21 UTC (permalink / raw)
  To: Stig Brautaset; +Cc: Org Mode

Hello,

Stig Brautaset <stig@brautaset.org> writes:

> This is required for me to be able to run tests on master with GNU Emacs
> 26.0.50 on macOS.

[...]

>        (require 'cl-lib)
> +      (require 'cl)

Thank you.

Actually, the proper fix would be to replace functions not working with
(require 'cl-lib).

Would you want to look into it?


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Add missing require in org-test.el
  2017-07-14 17:21 ` Nicolas Goaziou
@ 2017-07-14 19:26   ` Stig Brautaset
  0 siblings, 0 replies; 3+ messages in thread
From: Stig Brautaset @ 2017-07-14 19:26 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: Org Mode


Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>>        (require 'cl-lib)
>> +      (require 'cl)
>
> Thank you.
>
> Actually, the proper fix would be to replace functions not working with
> (require 'cl-lib).
>
> Would you want to look into it?

Sure! I'll try that.

Stig

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-07-14 19:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-14 13:51 [PATCH] Add missing require in org-test.el Stig Brautaset
2017-07-14 17:21 ` Nicolas Goaziou
2017-07-14 19:26   ` Stig Brautaset

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).