From mboxrd@z Thu Jan 1 00:00:00 1970 From: stardiviner Subject: Re: [PATCH 2/4] ob-clojure.el: Add ClojureScript interface Date: Thu, 25 Oct 2018 14:11:41 +0800 Message-ID: <874ldar1wi.fsf@gmail.com> References: <20180422205003.87836-1-roberthambrock@gmail.com> <20180422205003.87836-3-roberthambrock@gmail.com> Reply-To: numbchild@gmail.com Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFYs2-0002FO-1g for emacs-orgmode@gnu.org; Thu, 25 Oct 2018 02:11:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gFYry-0002Xp-Qv for emacs-orgmode@gnu.org; Thu, 25 Oct 2018 02:11:50 -0400 Received: from [61.175.244.13] (port=43895 helo=dark.localdomain) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gFYrw-0002WR-TQ for emacs-orgmode@gnu.org; Thu, 25 Oct 2018 02:11:46 -0400 In-reply-to: <20180422205003.87836-3-roberthambrock@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: roberthambrock@gmail.com Cc: emacs-orgmode@gnu.org, Nicolas Goaziou roberthambrock@gmail.com writes: > From: Robert Hambrock > > * lisp/ob-clojure.el (org-babel-execute:clojure): Implemented :target, > which allows selection of connection. > * lisp/ob-clojure.el (org-babel-execute:clojurescript): New > ClojureScript interface that uses :target flag to specify `cljs` > evaluation target. > --- > lisp/ob-clojure.el | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/lisp/ob-clojure.el b/lisp/ob-clojure.el > index 93674b552..7f7c24ff1 100644 > --- a/lisp/ob-clojure.el > +++ b/lisp/ob-clojure.el > @@ -129,7 +129,8 @@ using the :show-process parameter." > (cider > (require 'cider) > (let ((result-params (cdr (assq :result-params params))) > - (show (cdr (assq :show-process params)))) > + (show (cdr (assq :show-process params))) > + (connection (cider-current-connection (cdr (assq :target params))))) > (if (member show '(nil "no")) > ;; Run code without showing the process. > (progn > @@ -137,7 +138,7 @@ using the :show-process parameter." > (let ((nrepl-sync-request-timeout > org-babel-clojure-sync-nrepl-timeout)) > (nrepl-sync-request:eval expanded > - (cider-current-connection)))) > + connection))) > (setq result > (concat > (nrepl-dict-get response > @@ -171,7 +172,7 @@ using the :show-process parameter." > (nrepl--merge response resp) > ;; Update the status of the nREPL output session. > (setq status (nrepl-dict-get response "status"))) > - (cider-current-connection)) > + connection) > > ;; Wait until the nREPL code finished to be processed. > (while (not (member "done" status)) > @@ -211,6 +212,9 @@ using the :show-process parameter." > (condition-case nil (org-babel-script-escape result) > (error result))))) > > +(defun org-babel-execute:clojurescript (body params) > + (org-babel-execute:clojure body (cons '(:target . "cljs") params))) > + > (provide 'ob-clojure) > > ;;; ob-clojure.el ends here Hi, @roberthambrock. I would like to have ob-clojure support ClojureScript too. But seems this patch is not merged yet, for a long time. Can I modify this patch and send to Org Mode? @Nicolas, can I do this? set Git commit author as "roberthambrock", and commiter as me. -- [ stardiviner ] I try to make every word tell the meaning what I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3