From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH 2/2] test-ob-emacs-lisp: Test :lexical src block header
 argument
Date: Thu, 14 Mar 2019 23:38:32 +0100
Message-ID: <874l85ulnb.fsf@nicolasgoaziou.fr>
References: <87sgvpg3bq.fsf@gmail.com> <87y35hv6yg.fsf@nicolasgoaziou.fr>
	<87y35hs1ao.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:37022)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1h4Z9f-0001lW-92
	for emacs-orgmode@gnu.org; Thu, 14 Mar 2019 18:48:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1h4Yzm-00047o-RY
	for emacs-orgmode@gnu.org; Thu, 14 Mar 2019 18:38:39 -0400
Received: from relay9-d.mail.gandi.net ([217.70.183.199]:38917)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1h4Yzm-00044b-IS
	for emacs-orgmode@gnu.org; Thu, 14 Mar 2019 18:38:38 -0400
In-Reply-To: <87y35hs1ao.fsf@gmail.com> (Sebastian Miele's message of "Thu, 14
	Mar 2019 19:28:47 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Sebastian Miele <sebastian.miele@gmail.com>
Cc: emacs-orgmode@gnu.org

Sebastian Miele <sebastian.miele@gmail.com> writes:

> After some initial tooth-grinding,

My intent is not to be negative. I do understand that writing tests
takes time.

However, from experience, having to fix a regression when your only
indication comes from a test you do not fully understand is a pain. To
see what I mean, have a look at tests in
"test-ob-header-arg-defaults.el" and imagine one of them fails=E2=80=A6

> I did rewrite them, and actually like
> the result more than the previous version. Thank you for the suggestion!
>
> Here is the updated patch:

Thank you. I applied it.