From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] ox.el: Fix extra character deleted in
 org-export--update-included-link
Date: Tue, 11 Feb 2020 19:15:53 +0100
Message-ID: <874kvxxa5i.fsf@nicolasgoaziou.fr>
References: <86tv7lm79g.fsf@xkqr.org> <8736bhqftq.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:44730)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1j1a50-0007cJ-5u
 for emacs-orgmode@gnu.org; Tue, 11 Feb 2020 13:16:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mail@nicolasgoaziou.fr>) id 1j1a4y-0006v0-I1
 for emacs-orgmode@gnu.org; Tue, 11 Feb 2020 13:16:13 -0500
In-Reply-To: <8736bhqftq.fsf@gnu.org> (Bastien's message of "Tue, 11 Feb 2020
 16:55:13 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org>
To: Bastien <bzg@gnu.org>
Cc: Christoffer =?utf-8?Q?Stjernl=C3=B6f?= <a@xkqr.org>, emacs-orgmode@gnu.org

Hello,

Bastien <bzg@gnu.org> writes:

> Nicolas, does it look good to you?  

How would I dare to have an opinion m'lord? Only yours matters.

Christoffer, unfortunately, this patch is incorrect. It doesn't account
for a zero :post-blank value. For the record, (1-
(org-element-property :end ...)) is always a bad idea.

I pushed a fix, with a test. I let you check if the issue is resolved on
your side, and close the bug report if appropriate.

Thank you for the report.

-- 
Nicolas Goaziou