From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jack Kamm Subject: Re: [PATCH] Fix ob-python.el initiate session error with py-shell Date: Tue, 18 Feb 2020 09:07:38 -0800 Message-ID: <874kvnako5.fsf@gmail.com> References: <877e0kjbqq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:50970) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j46LX-0005Sx-8z for emacs-orgmode@gnu.org; Tue, 18 Feb 2020 12:07:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j46LW-0002vV-5m for emacs-orgmode@gnu.org; Tue, 18 Feb 2020 12:07:43 -0500 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:43658) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j46LW-0002us-0k for emacs-orgmode@gnu.org; Tue, 18 Feb 2020 12:07:42 -0500 Received: by mail-pg1-x541.google.com with SMTP id u12so10885058pgb.10 for ; Tue, 18 Feb 2020 09:07:41 -0800 (PST) In-Reply-To: <877e0kjbqq.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: numbchild@gmail.com, Org Mode Hi stardiviner, > This minor patch should fixed ~py-shell~ initiate Python session issue. It looks like this patch only affects users of python-mode.el. Since I don't use python-mode.el, I cannot test it. But the patch looks fine. Please add a commit message and changelog entry, and I'll merge it in. Now, a few general thoughts on python-mode.el: I'm a little surprised to see python-mode.el pop up, and that we have code in ob-python to explicitly support it. I thought it was obsolete ever since python.el was added to emacs 24. But, it looks like it's still receiving commits in 2020, so I guess I was wrong. In a sense, it doesn't seem right to have code in ob-python explicitly supporting python-mode.el. While at one point it may have been a contender with python.el as the standard Python mode, at this point it's just another third-party package like elpy, jedi, etc, none of which get explicit support. I don't want to break anyone's setup without further investigation, so I'll leave the python-mode.el support as is, for now. But a warning, this may change in future if we ever refactor ob-python.