From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uMH9Ms9J1F74CgAA0tVLHw (envelope-from ) for ; Mon, 01 Jun 2020 00:20:31 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UPnXLs9J1F5CJgAAB5/wlQ (envelope-from ) for ; Mon, 01 Jun 2020 00:20:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AF258940144 for ; Mon, 1 Jun 2020 00:20:30 +0000 (UTC) Received: from localhost ([::1]:39140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfYBo-0005TN-OJ for larch@yhetil.org; Sun, 31 May 2020 20:20:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfYBD-0005TB-Oa for emacs-orgmode@gnu.org; Sun, 31 May 2020 20:19:51 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:63202) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfYBA-00031t-Uu for emacs-orgmode@gnu.org; Sun, 31 May 2020 20:19:50 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 448506A41A; Sun, 31 May 2020 20:19:46 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=Bz48LwB5BfSM 2TRmth0rV8hTj7Q=; b=u47CLAv9Sud+d+FrnevtGymAZIkVOb65waIQxDwor5K0 FXf5zAn4ADTQtZd5ARAew/oqg09vucERIDbQZXTDXxPRkQk1rje0LLA8wdTuyTsF kFXx9GeUCOMHiv/7U8GokFM3IIhfak/alnnisgKRPPtIJcPsgsy+AJF+pt28D5w= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 3C1D66A419; Sun, 31 May 2020 20:19:46 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=PK+1FMBQ23+CG5m7gW8Dcvzm8wzUSNhhwTbZ3ij5nXg=; b=rlYlwTt6QFWAOJeIQyUYs8+n5ih2ndiUTMuFIHX3CMrAtmB9M4eVY0f0hS0wxYcNK/TqE9nfRLC7ZqCDqF1wIBf1+iGGS0MBsGBbWqsbndDZuRFYJd0ZGSO51OhDJGLVTjb29/ZsACAntQs0qNYNzCEhQJ8ehVld7AWl3kZ0WJE= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id AE7306A418; Sun, 31 May 2020 20:19:45 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Mario Frasca Subject: Re: `with` as a list. In-Reply-To: References: <87h7vxuq8i.fsf@kyleam.com> <1a448b21-cdf9-467d-e707-471bb8c01781@anche.no> Date: Mon, 01 Jun 2020 00:19:44 +0000 Message-ID: <874krvvdr3.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Pobox-Relay-ID: 98D1E1D6-A39D-11EA-B773-D1361DBA3BAF-24757444!pb-smtp2.pobox.com Received-SPF: pass client-ip=64.147.108.71; envelope-from=kyle@kyleam.com; helo=pb-smtp2.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/31 20:19:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=u47CLAv9; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=rlYlwTt6; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: ZioI2iWz0vH0 Mario Frasca writes: > On 30/05/2020 16:29, Mario Frasca wrote: >> I hope to be back soon with a single commit...=20 > > one doubt.=C2=A0 what's the point of having me squash all in a single com= mit,=20 > when I do not have write access to the repository?=C2=A0 To provide me or another committer with a polished, final state to apply, along with a commit message that follows the convention mentioned at and ideally explains why the change should be applied. (The rationale you sent in your first message could be adapted for this.) You've been sending a diff, presumably from the point you branched off of to the tip of your branch. In that case, you're already presenting each iteration you've sent as one change; it just lacks a commit message. Just for clarity: In this case, I think the change proposed so far makes sense to present as a single commit. I'm not claiming that in general a patch series should be reduced to _one_ commit. > if we were on github, I would be working on a pull request, which > would have a description and a title, and contain several commits.=C2=A0 If I were reviewing a pull request from you, I would still request that you not pile fixup commits on top and that you instead rewrite/polish the series to address feedback. People have strong opinions in both directions on this, and I hope this thread doesn't derail into a discussion of those. My point is just that this workflow is not unique to mailing list patch submission.