emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Mario Frasca <mario@anche.no>
Cc: emacs-orgmode@gnu.org
Subject: Re: `with` as a list.
Date: Mon, 01 Jun 2020 00:19:44 +0000	[thread overview]
Message-ID: <874krvvdr3.fsf@kyleam.com> (raw)
In-Reply-To: <fdfb3c44-1608-b603-f29b-51452139b19a@anche.no>

Mario Frasca writes:

> On 30/05/2020 16:29, Mario Frasca wrote:
>> I hope to be back soon with a single commit... 
> one doubt.  what's the point of having me squash all in a single commit, 
> when I do not have write access to the repository? 

To provide me or another committer with a polished, final state to
apply, along with a commit message that follows the convention mentioned
at <https://orgmode.org/worg/org-contribute.html> and ideally explains
why the change should be applied.  (The rationale you sent in your first
message could be adapted for this.)  You've been sending a diff,
presumably from the point you branched off of to the tip of your branch.
In that case, you're already presenting each iteration you've sent as
one change; it just lacks a commit message.

Just for clarity: In this case, I think the change proposed so far makes
sense to present as a single commit.  I'm not claiming that in general a
patch series should be reduced to _one_ commit.

> if we were on github, I would be working on a pull request, which
> would have a description and a title, and contain several commits. 

If I were reviewing a pull request from you, I would still request that
you not pile fixup commits on top and that you instead rewrite/polish
the series to address feedback.  People have strong opinions in both
directions on this, and I hope this thread doesn't derail into a
discussion of those.  My point is just that this workflow is not unique
to mailing list patch submission.

  reply	other threads:[~2020-06-01  0:20 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22 16:07 `with` as a list Mario Frasca
2020-05-28 13:34 ` [PATCH] [FEATURE] " Mario Frasca
2020-05-30  6:22 ` Kyle Meyer
2020-05-30 14:23   ` Mario Frasca
2020-05-30 14:38     ` Mario Frasca
2020-05-30 20:23     ` Kyle Meyer
2020-05-30 21:29       ` Mario Frasca
2020-05-31 20:18         ` Mario Frasca
2020-06-01  0:19           ` Kyle Meyer [this message]
2020-06-01  1:47             ` Mario Frasca
2020-06-01  2:31               ` Kyle Meyer
2020-06-03 15:09                 ` Mario Frasca
2020-06-03 15:13                   ` Bastien
2020-06-03 15:18                     ` Mario Frasca
2020-06-03 15:29                       ` Bastien
2020-06-03 17:08                         ` Mario Frasca
2020-06-03 22:15                         ` Mario Frasca
2020-06-03 15:25                     ` Mario Frasca
2020-06-03 15:30                       ` Bastien
2020-05-30 16:01   ` Mario Frasca
2020-05-30 20:25     ` Kyle Meyer
2020-05-30 21:36       ` Mario Frasca
2020-05-31  0:36         ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874krvvdr3.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mario@anche.no \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).