From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2MhJEPDC2V7fJgAA0tVLHw (envelope-from ) for ; Fri, 05 Jun 2020 03:58:40 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 2OkdDPDC2V6VBQAAbx9fmQ (envelope-from ) for ; Fri, 05 Jun 2020 03:58:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 01FD19402A0 for ; Fri, 5 Jun 2020 03:58:38 +0000 (UTC) Received: from localhost ([::1]:57912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jh3V6-0007QT-KG for larch@yhetil.org; Thu, 04 Jun 2020 23:58:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jh3Ul-0007P4-77 for emacs-orgmode@gnu.org; Thu, 04 Jun 2020 23:58:15 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:55531) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jh3Uj-0005Ww-Ki; Thu, 04 Jun 2020 23:58:14 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id AE65DC96BF; Thu, 4 Jun 2020 23:58:09 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=kCjmg4ZL853gu7amHYayoM6HD9A=; b=GwkQzk 2xdiANSYK1mstvly7NayB70IhJ+q2OjHRpbkowoWMUF+2/UHnjyM3RKqiwoBfP8B nYoSzAhE/xmUrabwtUszmgcuBdUYROaoNIAOmnyUWsj/MDMwa3wAiIkW+pQsyYjq YxiSCWHPXPqVCPLNAHhqBMWPrK1Eh53NjCGNk= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id A76FBC96BD; Thu, 4 Jun 2020 23:58:09 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=bC/fPKxhqjImntAkTWLEemwjm/5JAf4FPGexkRDab2I=; b=Lp6DJoAlCbjvl6dkC0lR+a/31etUz6QzLN8zApqPwy5YmaWeyLL7qhQiVEv3THG1BuGqwLE3nST0WwnHN19Pb4Fkfgh7F99Eg+hK4iZAKL0GOeK74HDiiuCcFNCALNcv250K8KWbupMrwR+/ruXROpwn+RBRrx7m3zLyy1/zQJo= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 14FF6C96BC; Thu, 4 Jun 2020 23:58:07 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Bastien , Stefan Kangas Subject: Re: [PATCH] New function org-agenda-filter-set In-Reply-To: <87k10r7xwn.fsf@bzg.fr> References: <87k10r7xwn.fsf@bzg.fr> Date: Fri, 05 Jun 2020 03:58:05 +0000 Message-ID: <874krqw4du.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: C37F7862-A6E0-11EA-B02A-8D86F504CC47-24757444!pb-smtp21.pobox.com Received-SPF: pass client-ip=173.228.157.53; envelope-from=kyle@kyleam.com; helo=pb-smtp21.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/04 23:58:10 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=GwkQzk 2; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=Lp6DJoAl; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: XtMEP/bcoG1w Bastien writes: > I've seen problems with this new function when completing in agendas: > hitting '/' does not see what tags are available for completion in the > current buffer. > > I'm reverting e9b1b8fde5 from master for now. If you see what's wrong, > please resubmit a patch. Stepping through both versions, it looks like the crucial thing is that org-agenda-get-represented-tags needs to be called _before_ the completion function. If it's not, org-agenda-filter-completion-function calls -get-represented-tags with an unset cache, and it returns nil because the (derived-mode-p 'org-agenda-mode) condition is nil. The same goes for org-agenda-get-represented-categories.