From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6ObpAN08+F6lGgAA0tVLHw (envelope-from ) for ; Sun, 28 Jun 2020 06:46:53 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iF5ZONw8+F4EJQAAbx9fmQ (envelope-from ) for ; Sun, 28 Jun 2020 06:46:52 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2F9149400BB for ; Sun, 28 Jun 2020 06:46:52 +0000 (UTC) Received: from localhost ([::1]:51726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpR5V-0004zD-HW for larch@yhetil.org; Sun, 28 Jun 2020 02:46:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpR57-0004yt-5d for emacs-orgmode@gnu.org; Sun, 28 Jun 2020 02:46:25 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:54233) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jpR54-0000Y3-UV for emacs-orgmode@gnu.org; Sun, 28 Jun 2020 02:46:24 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay11.mail.gandi.net (Postfix) with ESMTPSA id A4725100002; Sun, 28 Jun 2020 06:46:17 +0000 (UTC) From: Nicolas Goaziou To: Mario Frasca Subject: Re: [PATCH] may we focus on readability? References: <871rmhe93z.fsf@nicolasgoaziou.fr> <1a4fa99e-26b3-db80-e292-1001d762f8d5@anche.no> Mail-Followup-To: Mario Frasca , emacs-orgmode@gnu.org Date: Sun, 28 Jun 2020 08:46:16 +0200 In-Reply-To: (Mario Frasca's message of "Mon, 15 Jun 2020 15:52:11 -0500") Message-ID: <874kqvzo07.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.231; envelope-from=mail@nicolasgoaziou.fr; helo=relay11.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/28 02:46:18 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: S6YFFv/vFbuY Hello, Mario Frasca writes: > second thought about testing: > > if I did that, it would become longer than 15 lines, I would need > refactoring quite a bit of stuff, and both things would require time, > bureaucratic time, and programming time. > > I had a closer look at my changes, re-read it, and used it a bit, and > I think this is o.k. > > see it yourself, when we have the agreement allowing you accept > changes longer than 15 lines, I'll consider the needed refactoring and > test-writing. I slightly changed the commit message and applied these changes. Thank you. Regards, -- Nicolas Goaziou