emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Mario Frasca <mario@anche.no>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] may we focus on readability?
Date: Sun, 28 Jun 2020 08:46:16 +0200	[thread overview]
Message-ID: <874kqvzo07.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <d9c0a5f2-bd96-0a1d-66d2-d540dc938be3@anche.no> (Mario Frasca's message of "Mon, 15 Jun 2020 15:52:11 -0500")

Hello,

Mario Frasca <mario@anche.no> writes:

> second thought about testing:
>
> if I did that, it would become longer than 15 lines, I would need
> refactoring quite a bit of stuff, and both things would require time,
> bureaucratic time, and programming time.
>
> I had a closer look at my changes, re-read it, and used it a bit, and
> I think this is o.k.
>
> see it yourself, when we have the agreement allowing you accept
> changes longer than 15 lines, I'll consider the needed refactoring and
> test-writing.

I slightly changed the commit message and applied these changes.

Thank you.

Regards,
-- 
Nicolas Goaziou


  parent reply	other threads:[~2020-06-28  6:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-14 16:47 [PATCH] may we focus on readability? Mario Frasca
2020-06-14 17:24 ` tomas
2020-06-14 19:28   ` Nicolas Goaziou
2020-06-14 19:30     ` tomas
2020-06-14 19:32 ` Nicolas Goaziou
2020-06-15 14:49   ` Mario Frasca
2020-06-15 20:52     ` Mario Frasca
2020-06-16 16:56       ` Nicolas Goaziou
2020-06-16 17:26         ` Mario Frasca
2020-06-28  6:47           ` Nicolas Goaziou
2020-06-28  6:46       ` Nicolas Goaziou [this message]
2020-06-16 15:29     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kqvzo07.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=mario@anche.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).