From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aPf0N/0mbV8JcAAA0tVLHw (envelope-from ) for ; Thu, 24 Sep 2020 23:08:45 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id yJzaM/0mbV/PSwAA1q6Kng (envelope-from ) for ; Thu, 24 Sep 2020 23:08:45 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 347479400BF for ; Thu, 24 Sep 2020 23:08:45 +0000 (UTC) Received: from localhost ([::1]:33744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLaLz-0007UI-5N for larch@yhetil.org; Thu, 24 Sep 2020 19:08:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLaLH-0007TK-Pa for emacs-orgmode@gnu.org; Thu, 24 Sep 2020 19:08:00 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:57719) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLaLE-0007W3-W1 for emacs-orgmode@gnu.org; Thu, 24 Sep 2020 19:07:59 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 32F3FE4654; Thu, 24 Sep 2020 19:07:55 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=famDJhets0OR3sc5Ud13xp9irGY=; b=CSRrgy UCISKnrmYiygfEE07k8SGULwFiun+Phn5Zch7nAatMYh7GMhKvfjcG0hEN3pMEXb Ofw+LZrud3B20P2CXYqD1QJIQH1QG3tpvGVRmNjGfEaQqdFtaf8ZtxIsOnknbu1/ DvF/EY6njkQ7Z4qvd/cxjymsyGBc4oophbkWA= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 11A09E4653; Thu, 24 Sep 2020 19:07:55 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=ljdwR2S6UHXZt8YV1CPz34U0nPN9RP/3Q6ib74cfh94=; b=pVtxcgHZ/AkSlah5jl2ERsgy4uKJXY2sLgdC2OQtCNe9sUKnXUcL6NQJwimGFbd3DP22H2tK+l8aQJu9G1CTg4z6L9FanVmdfxvFNJLgdxjXkp/gTn2ggSTcCc/9YX1lIxLM1kEuQzLgxiQs5bioAGO23NcHMWpawuXiUFSbGIU= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 76CF0E464F; Thu, 24 Sep 2020 19:07:52 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Matt Huszagh Subject: Re: [PATCH] Omit file description when :file-desc has nil value In-Reply-To: <87eemrzokq.fsf@gmail.com> References: <87r1rf35bb.fsf@kyleam.com> <87pn6uzq41.fsf@gmail.com> <877dsv3r1w.fsf@gmail.com> <87a6xfvjck.fsf@kyleam.com> <87eemrzokq.fsf@gmail.com> Date: Thu, 24 Sep 2020 19:07:50 -0400 Message-ID: <874knmvkmx.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: C5DAEC22-FEBA-11EA-A223-F0EA2EB3C613-24757444!pb-smtp20.pobox.com Received-SPF: pass client-ip=173.228.157.52; envelope-from=kyle@kyleam.com; helo=pb-smtp20.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/24 19:07:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emacs-Orgmode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=CSRrgy U; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=pVtxcgHZ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: B57ut6sN2mcW Matt Huszagh writes: > This patch looks good. I've tested it and it works well for me. Thanks > for coming up with a good solution! Thanks for testing it out. > I think the one thing still missing is some documentation in the info > manual. Something along the lines of [...] Yep, the manual should definitely be updated in a final patch. What you suggest looks good to me. > Feel free to add this (or something else) to your patch. Or, if you'd > prefer that I created a patch for it, let me know. I'd be happy for you to take what I sent and work it into a proper patch. Here are some other loose ends in addition to the manual update you mentioned: * a NEWS entry for 9.5 * decide whether (:file-desc . []) should be handled explicitly rather than the current "any value that org-babel-read doesn't map to nil or a string" * check that there's a test case for each :file-desc scenario Thanks.