From: Kyle Meyer <kyle@kyleam.com>
To: Matt Huszagh <huszaghmatt@gmail.com>
Cc: Emacs-Orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Omit file description when :file-desc has nil value
Date: Thu, 24 Sep 2020 19:07:50 -0400 [thread overview]
Message-ID: <874knmvkmx.fsf@kyleam.com> (raw)
In-Reply-To: <87eemrzokq.fsf@gmail.com>
Matt Huszagh writes:
> This patch looks good. I've tested it and it works well for me. Thanks
> for coming up with a good solution!
Thanks for testing it out.
> I think the one thing still missing is some documentation in the info
> manual. Something along the lines of [...]
Yep, the manual should definitely be updated in a final patch. What you
suggest looks good to me.
> Feel free to add this (or something else) to your patch. Or, if you'd
> prefer that I created a patch for it, let me know.
I'd be happy for you to take what I sent and work it into a proper
patch. Here are some other loose ends in addition to the manual update
you mentioned:
* a NEWS entry for 9.5
* decide whether (:file-desc . []) should be handled explicitly rather
than the current "any value that org-babel-read doesn't map to nil
or a string"
* check that there's a test case for each :file-desc scenario
Thanks.
next prev parent reply other threads:[~2020-09-24 23:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 19:19 [PATCH] Omit file description when :file-desc has nil value Huszaghmatt
2020-09-06 4:19 ` Kyle Meyer
2020-09-09 19:50 ` Matt Huszagh
2020-09-15 17:09 ` Matt Huszagh
2020-09-24 5:23 ` Kyle Meyer
2020-09-24 6:16 ` Matt Huszagh
2020-09-24 23:07 ` Kyle Meyer [this message]
2020-09-29 21:33 ` Matt Huszagh
2020-10-03 6:08 ` Kyle Meyer
2020-10-06 13:17 ` Matt Huszagh
2020-10-07 3:19 ` Kyle Meyer
-- strict thread matches above, loose matches on Subject: below --
2020-09-03 6:19 Matt Huszagh
2020-09-03 6:53 ` Matt Huszagh
2020-09-04 5:21 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874knmvkmx.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=huszaghmatt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).