emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Timothy <tecosaur@gmail.com>
Cc: org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Allow LaTeX reference command (\ref) to be customised
Date: Wed, 09 Jun 2021 13:52:04 +0200	[thread overview]
Message-ID: <874ke7i7bv.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <871r9bpz18.fsf@gmail.com> (Timothy's message of "Wed, 09 Jun 2021 10:11:47 +0800")

Hello,

Timothy <tecosaur@gmail.com> writes:

> I'm wondering if you've had a chance to take a look yet? (just making
> sure this hasn't slipped by, given your recent replies in other
> threads).

I agree there is no good reason to hard-code "\ref", but, off the top of
my head, there may be a couple of things to consider:

1. There is still a dangling \ref in `org-latex-footnote-defined-format';

2. This change is already somewhat trivial using a link filter:

     (defun my-ref-link-filter (s &rest _)
       (replace-regexp-in-string (rx string-start "\\ref") "\\foo" s nil t))

     (add-to-list 'org-export-filter-link-functions #'my-ref-link-filter)

3. \hyperref is still hard-coded in `org-latex-link'; your patch could
   look like a partial solution.

Those are not strong objections, so if you think none of them is worth
considering, then I'm fine with your patch.

Regards,
-- 
Nicolas Goaziou


  reply	other threads:[~2021-06-09 11:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-06 18:19 [PATCH] Allow LaTeX reference command (\ref) to be customised Timothy
2021-06-06 18:29 ` Juan Manuel Macías
2021-06-06 18:39 ` Bruce D'Arcus
2021-06-09  2:11 ` Timothy
2021-06-09 11:52   ` Nicolas Goaziou [this message]
2021-06-09 13:36     ` Timothy
2021-06-09 15:08       ` Nicolas Goaziou
2021-06-09 17:38         ` Timothy
2021-06-11 16:44           ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ke7i7bv.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=tecosaur@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).