From: Bastien <bzg@gnu.org>
To: Timothy <tecosaur@gmail.com>
Cc: Org-Mode Mailing List <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Prevent displayed images from being re-scaled
Date: Sun, 03 Oct 2021 06:57:09 +0200 [thread overview]
Message-ID: <874k9y7lju.fsf@gnu.org> (raw)
In-Reply-To: <87bl4bcxe3.fsf@gmail.com> (Timothy's message of "Wed, 29 Sep 2021 21:33:34 +0800")
Hi Timothy,
Timothy <tecosaur@gmail.com> writes:
> From 9c34dd6aba62d734f6ae9aecaffa76a0250bf495 Mon Sep 17 00:00:00 2001
> From: TEC <tec@tecosaur.com>
> Date: Wed, 29 Sep 2021 21:29:27 +0800
> Subject: [PATCH] org: Don't change image size based on font size
>
> * lisp/org.el (org--create-inline-image): When `create-image' is called
> without the :scale parameter, the image size is expanded based on the
> default font size (if it is larger than 10px). When displaying images
> with a specified width in Org buffers, either in pixels or proportional
> to the text width, this width should not be modified according the to
> font size. Giving a :scale parameter of 1 prevents this font-size based
> rescaling.
Nitpick: I suggest shortening the ChangeLog part like this:
* lisp/org.el (org--create-inline-image): Set :scale parameter to 1 to
prevent font-size based rescaling.
When `create-image' is called without the :scale parameter, the image
size is expanded based on the default font size (if it is larger than
10px). When displaying images with a specified width in Org buffers,
either in pixels or proportional to the text width, this width should
not be modified according the to font size. Giving a :scale parameter
of 1 prevents this font-size based rescaling.
The ChangeLog part should not be too verbose, you can add explanations
after it.
Thanks,
--
Bastien
next prev parent reply other threads:[~2021-10-03 4:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 13:33 [PATCH] Prevent displayed images from being re-scaled Timothy
2021-10-02 20:30 ` Timothy
2021-10-25 13:49 ` Timothy
2021-10-03 4:57 ` Bastien [this message]
2021-10-03 5:45 ` Timothy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k9y7lju.fsf@gnu.org \
--to=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=tecosaur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).